Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

[Sergei Shtylyov <sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>]

Hello.

Felipe Balbi wrote:

>>    Why always "ick"?! Do you think OMAPs are the only boards using MUSB 
>> out there?
>>     
>
> err, I'm afraid you have to read more about clock framework. The clock
> name should not matter when you issue clk_get().

   It depends on the matching type determined from a clkdev matching 
table -- see dm644x_clks[] in arch/mach-davinci/dm644x.c as an example: 
'struct davinci_clk' incorporates 'struct clk_lookup', and where its 1st 
member is initialized, the matching is done by device, where its second 
member is initialized, the matching is done by clock name -- see 
clk_find() in arch/arm/common/clkdev.c for the logic.

> I used the shortest
> name that came to my mind. could've been "usb", "usb_clock",
> "musb_otg_default_clock". It doesn't matter.

   I know for sure that it still *can* matter with clkdev, and I do use 
matching by clock name with DA8xx/OMAP-L1x glue layer. So I' strongly 
against this patch.

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html