From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling Date: Wed, 30 Dec 2009 16:06:19 +0300 Message-ID: <4B3B504B.4020602@ru.mvista.com> References: <1262127567-15202-1-git-send-email-felipe.balbi@nokia.com> <1262127567-15202-8-git-send-email-felipe.balbi@nokia.com> <4B3B3720.9070205@ru.mvista.com> <1262174012.28789.178.camel@gandalf> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1262174012.28789.178.camel@gandalf> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org Cc: Felipe Balbi , tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org Hello. Felipe Balbi wrote: >> Why always "ick"?! Do you think OMAPs are the only boards using MUSB >> out there? >> > > err, I'm afraid you have to read more about clock framework. The clock > name should not matter when you issue clk_get(). It depends on the matching type determined from a clkdev matching table -- see dm644x_clks[] in arch/mach-davinci/dm644x.c as an example: 'struct davinci_clk' incorporates 'struct clk_lookup', and where its 1st member is initialized, the matching is done by device, where its second member is initialized, the matching is done by clock name -- see clk_find() in arch/arm/common/clkdev.c for the logic. > I used the shortest > name that came to my mind. could've been "usb", "usb_clock", > "musb_otg_default_clock". It doesn't matter. I know for sure that it still *can* matter with clkdev, and I do use matching by clock name with DA8xx/OMAP-L1x glue layer. So I' strongly against this patch. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html