From: Sergei Shtylyov <sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
To: me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org
Cc: Felipe Balbi
<felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling
Date: Wed, 30 Dec 2009 16:43:12 +0300 [thread overview]
Message-ID: <4B3B58F0.2070903@ru.mvista.com> (raw)
In-Reply-To: <1262179795.17250.7.camel@gandalf>
Hello.
Felipe Balbi wrote:
>> Gotcha. This will match in clk_find() by both device and clock name,
>> so clk_get() will fail with your patch.
>>
>
> then, when it doesn't find, it'll try device id only:
>
> /*
> * Find the correct struct clk for the device and connection ID.
> * We do slightly fuzzy matching here:
> * An entry with a NULL ID is assumed to be a wildcard.
> * If an entry has a device ID, it must match
> * If an entry has a connection ID, it must match
> * Then we take the most specific entry - with the following
> * order of precidence: dev+con > dev only > con only.
> */
>
> and then we have found our clock :-)
Hm, you're right, I haven't completely followed the logic there... in
any case, specifying con_id wasn't really needed.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-30 13:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 22:59 [patch-v2.6.34 0/9] arm omap patches for -next merge window Felipe Balbi
[not found] ` <1262127567-15202-1-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-29 22:59 ` [patch-v2.6.34 1/9] arm: omap: musb: remove unused data Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 3/9] arm: omap: musb: remove unused soft_con field Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 5/9] arm: omap: musb: remove unnecessary return Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling Felipe Balbi
[not found] ` <1262127567-15202-8-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-30 11:18 ` Sergei Shtylyov
[not found] ` <4B3B3720.9070205-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-12-30 11:53 ` Felipe Balbi
2009-12-30 13:06 ` Sergei Shtylyov
[not found] ` <4B3B504B.4020602-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-12-30 13:14 ` Felipe Balbi
2009-12-30 13:20 ` Felipe Balbi
2009-12-30 13:25 ` Sergei Shtylyov
[not found] ` <4B3B54E1.9010600-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-12-30 13:29 ` Felipe Balbi
2009-12-30 13:43 ` Sergei Shtylyov [this message]
[not found] ` <4B3B58F0.2070903-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-12-30 13:46 ` Felipe Balbi
2009-12-30 14:45 ` Sergei Shtylyov
2009-12-29 22:59 ` [patch-v2.6.34 2/9] arm: omap: musb: we can use clk framework Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 4/9] arm: omap: musb: remove unused dma data Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 6/9] arm: omap: gpmc: avoid section definitions on headers Felipe Balbi
2009-12-29 22:59 ` [patch-v2.6.34 8/9] arm: omap: musb: do not pass clock name to driver Felipe Balbi
2009-12-30 11:23 ` Sergei Shtylyov
2009-12-30 11:55 ` Felipe Balbi
2009-12-30 13:10 ` Sergei Shtylyov
2009-12-29 22:59 ` [patch-v2.6.34 9/9] arm: omap: musb: get rid of dyn_fifo Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3B58F0.2070903@ru.mvista.com \
--to=sshtylyov-hkdhdckh98+b+jhodadfcq@public.gmane.org \
--cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox