From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling Date: Wed, 30 Dec 2009 16:43:12 +0300 Message-ID: <4B3B58F0.2070903@ru.mvista.com> References: <1262127567-15202-1-git-send-email-felipe.balbi@nokia.com> <1262127567-15202-8-git-send-email-felipe.balbi@nokia.com> <4B3B3720.9070205@ru.mvista.com> <1262174012.28789.178.camel@gandalf> <4B3B504B.4020602@ru.mvista.com> <1262178881.17250.1.camel@gandalf> <4B3B54E1.9010600@ru.mvista.com> <1262179795.17250.7.camel@gandalf> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1262179795.17250.7.camel@gandalf> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org Cc: Felipe Balbi , tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org Hello. Felipe Balbi wrote: >> Gotcha. This will match in clk_find() by both device and clock name, >> so clk_get() will fail with your patch. >> > > then, when it doesn't find, it'll try device id only: > > /* > * Find the correct struct clk for the device and connection ID. > * We do slightly fuzzy matching here: > * An entry with a NULL ID is assumed to be a wildcard. > * If an entry has a device ID, it must match > * If an entry has a connection ID, it must match > * Then we take the most specific entry - with the following > * order of precidence: dev+con > dev only > con only. > */ > > and then we have found our clock :-) Hm, you're right, I haven't completely followed the logic there... in any case, specifying con_id wasn't really needed. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html