public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP3: add missing parentheses
@ 2009-12-23  1:42 Roel Kluin
  0 siblings, 0 replies; 3+ messages in thread
From: Roel Kluin @ 2009-12-23  1:42 UTC (permalink / raw)
  To: Tony Lindgren, linux-omap@vger.kernel.org, Andrew Morton, LKML

not(!) has a higher precedence than bit and(&).

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 arch/arm/plat-omap/include/plat/control.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/control.h b/arch/arm/plat-omap/include/plat/control.h
index 2ae8843..a745d62 100644
--- a/arch/arm/plat-omap/include/plat/control.h
+++ b/arch/arm/plat-omap/include/plat/control.h
@@ -147,7 +147,7 @@
 #define OMAP343X_CONTROL_IVA2_BOOTADDR	(OMAP2_CONTROL_GENERAL + 0x0190)
 #define OMAP343X_CONTROL_IVA2_BOOTMOD	(OMAP2_CONTROL_GENERAL + 0x0194)
 #define OMAP343X_CONTROL_DEBOBS(i)	(OMAP2_CONTROL_GENERAL + 0x01B0 \
-					+ ((i) >> 1) * 4 + (!(i) & 1) * 2)
+					+ ((i) >> 1) * 4 + (!((i) & 1)) * 2)
 #define OMAP343X_CONTROL_PROG_IO0	(OMAP2_CONTROL_GENERAL + 0x01D4)
 #define OMAP343X_CONTROL_PROG_IO1	(OMAP2_CONTROL_GENERAL + 0x01D8)
 #define OMAP343X_CONTROL_DSS_DPLL_SPREADING	(OMAP2_CONTROL_GENERAL + 0x01E0)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] OMAP3: add missing parentheses
@ 2010-01-06 22:22 Roel Kluin
  2010-01-07  0:03 ` [APPLIED] " Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2010-01-06 22:22 UTC (permalink / raw)
  To: linux-omap@vger.kernel.org, Tony Lindgren

`!' has a higher precedence than `&' so parentheses are required.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
 arch/arm/mach-omap2/pm34xx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 81ed252..c6cc809 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -124,8 +124,8 @@ static void omap3_core_save_context(void)
 	control_padconf_off |= START_PADCONF_SAVE;
 	omap_ctrl_writel(control_padconf_off, OMAP343X_CONTROL_PADCONF_OFF);
 	/* wait for the save to complete */
-	while (!omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
-			& PADCONF_SAVE_DONE)
+	while (!(omap_ctrl_readl(OMAP343X_CONTROL_GENERAL_PURPOSE_STATUS)
+			& PADCONF_SAVE_DONE))
 		;
 	/* Save the Interrupt controller context */
 	omap_intc_save_context();

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [APPLIED] [PATCH] OMAP3: add missing parentheses
  2010-01-06 22:22 [PATCH] OMAP3: add missing parentheses Roel Kluin
@ 2010-01-07  0:03 ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2010-01-07  0:03 UTC (permalink / raw)
  To: linux-omap

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): e9a87c0b3ee1478c3309b1ffa75873a556fadcee

PatchWorks
http://patchwork.kernel.org/patch/71449/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e9a87c0b3ee1478c3309b1ffa75873a556fadcee



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-07  0:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-06 22:22 [PATCH] OMAP3: add missing parentheses Roel Kluin
2010-01-07  0:03 ` [APPLIED] " Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2009-12-23  1:42 Roel Kluin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox