From: Romit Dasgupta <romit@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 3/10] OPP layer and additional cleanups.
Date: Thu, 07 Jan 2010 18:20:35 +0530 [thread overview]
Message-ID: <4B45D89B.8090108@ti.com> (raw)
In-Reply-To: <4B42663F.6040501@ti.com>
>> diff --git a/arch/arm/plat-omap/omap-pm-srf.c b/arch/arm/plat-omap/omap-pm-srf.c
>> index f7bf353..0736d6a 100644
>> --- a/arch/arm/plat-omap/omap-pm-srf.c
>> +++ b/arch/arm/plat-omap/omap-pm-srf.c
>> @@ -25,10 +25,6 @@
>> #include <plat/resource.h>
>> #include <plat/omap_device.h>
>>
>> -struct omap_opp *dsp_opps;
>> -struct omap_opp *mpu_opps;
>> -struct omap_opp *l3_opps;
>> -
>> #define LAT_RES_POSTAMBLE "_latency"
>> #define MAX_LATENCY_RES_NAME 30
>>
>> @@ -78,16 +74,17 @@ void omap_pm_set_min_bus_tput(struct device *dev, u8 agent_id, unsigned long r)
>> WARN_ON(1);
>> return;
>> };
>> +#warning "Convert throughput to L3 frequency before invoking resource_request"
>>
>> if (r == 0) {
>> pr_debug("OMAP PM: remove min bus tput constraint: "
>> "dev %s for agent_id %d\n", dev_name(dev), agent_id);
>> - resource_release("vdd2_opp", dev);
>> + resource_release("l3_freq", dev);
>> } else {
>> pr_debug("OMAP PM: add min bus tput constraint: "
>> "dev %s for agent_id %d: rate %ld KiB\n",
>> dev_name(dev), agent_id, r);
>> - resource_request("vdd2_opp", dev, r);
>> + resource_request("l3_freq", dev, r);
>> }
>> }
>>
>> @@ -168,42 +165,27 @@ void omap_pm_set_max_sdma_lat(struct device *dev, long t)
>>
>
> you may want to split this out.
Yes, there is still a TODO on this patch. I will split it out once this is done.
>
prev parent reply other threads:[~2010-01-07 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 13:29 [PATCH 3/10] OPP layer and additional cleanups Romit Dasgupta
[not found] ` <4B42663F.6040501@ti.com>
2010-01-07 12:50 ` Romit Dasgupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B45D89B.8090108@ti.com \
--to=romit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox