* [PATCH] omap: serial: fix coding style indentaion
@ 2010-01-07 18:49 Vikram Pandita
2010-01-07 19:06 ` Nishanth Menon
0 siblings, 1 reply; 2+ messages in thread
From: Vikram Pandita @ 2010-01-07 18:49 UTC (permalink / raw)
To: linux-omap; +Cc: Vikram Pandita
Just fix coding style indentaion as per checkpatch
No logical code change.
Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
arch/arm/mach-omap2/serial.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index 8c964be..467e5de 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -694,15 +694,15 @@ void __init omap_serial_init_port(int port)
DEV_CREATE_FILE(dev, &dev_attr_sleep_timeout);
}
- /* omap44xx: Never read empty UART fifo
- * omap3xxx: Never read empty UART fifo on UARTs
- * with IP rev >=0x52
- */
- if (cpu_is_omap44xx())
- uart->p->serial_in = serial_in_override;
- else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
- >= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
- uart->p->serial_in = serial_in_override;
+ /* omap44xx: Never read empty UART fifo
+ * omap3xxx: Never read empty UART fifo on UARTs
+ * with IP rev >=0x52
+ */
+ if (cpu_is_omap44xx())
+ uart->p->serial_in = serial_in_override;
+ else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
+ >= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
+ uart->p->serial_in = serial_in_override;
}
/**
--
1.6.6.rc0.66.ge160d
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omap: serial: fix coding style indentaion
2010-01-07 18:49 [PATCH] omap: serial: fix coding style indentaion Vikram Pandita
@ 2010-01-07 19:06 ` Nishanth Menon
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2010-01-07 19:06 UTC (permalink / raw)
To: Pandita, Vikram; +Cc: linux-omap@vger.kernel.org
Pandita, Vikram had written, on 01/07/2010 12:49 PM, the following:
> Just fix coding style indentaion as per checkpatch
> No logical code change.
>
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
> arch/arm/mach-omap2/serial.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 8c964be..467e5de 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -694,15 +694,15 @@ void __init omap_serial_init_port(int port)
> DEV_CREATE_FILE(dev, &dev_attr_sleep_timeout);
> }
>
> - /* omap44xx: Never read empty UART fifo
> - * omap3xxx: Never read empty UART fifo on UARTs
> - * with IP rev >=0x52
> - */
> - if (cpu_is_omap44xx())
> - uart->p->serial_in = serial_in_override;
> - else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> - >= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> - uart->p->serial_in = serial_in_override;
> + /* omap44xx: Never read empty UART fifo
> + * omap3xxx: Never read empty UART fifo on UARTs
> + * with IP rev >=0x52
> + */
Since you are fixing the coding style, ;) multiline comment goes:
/*
* tada tada
*/
Ref: Documentation/CodingStyle Chapter 8: Commenting
> + if (cpu_is_omap44xx())
> + uart->p->serial_in = serial_in_override;
> + else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> + >= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> + uart->p->serial_in = serial_in_override;
> }
>
> /**
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-07 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-07 18:49 [PATCH] omap: serial: fix coding style indentaion Vikram Pandita
2010-01-07 19:06 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox