Re: [PATCH] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP

[Nishanth Menon <nm@ti.com>]

Govindarajan, Sriramakrishnan had written, on 01/08/2010 02:15 AM, the 
following:
> 
>> From: Menon, Nishanth
>> Govindarajan, Sriramakrishnan had written, on 01/07/2010 06:30 AM, the
>> following:
>>> From: Sriram <srk@ti.com>
>>>
>>> OMAP platforms(like OMAP3530) include DSP or other co-processors
>>> for media acceleration. when carving out memory for the
>>> accelerators we can end up creating a hole in the memory map
>>> of sort:
>>> <kernel memory><hole(memory for accelerator)><kernel memory>
>>>
>>> To handle such a memory configuration ARCH_HAS_HOLES_MEMORYMODEL
>>> has to be enabled. For further information refer discussion at:
>>> http://www.mail-archive.com/linux-omap@vger.kernl.org/msg15262.html.
>> pls check the link: I see "The document you were looking for was not
>> found."
> 
> The URL is spelt incorrectly. Here is the correct URL:
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg15262.html
> 
>>>  	select GENERIC_TIME
>>>  	select GENERIC_CLOCKEVENTS
>>> +	select ARCH_HAS_HOLES_MEMORYMODEL
>> why enable this for all OMAPs?
> 
> I have tested this on several OMAP3 platforms and this feature is required
> Wherever some memory needs to be reserved for media accelerators - hence it
> Would be handy for earlier OMAP platforms as well
I understand that you have tested with OMAP3. my question is you have 
handled this as per the diff
@@ -699,6 +699,7 @@ config ARCH_OMAP
to ARCH_OMAP

is this good for OMAP1510, 1610, 1710, 2420,2430, 770 etc..?

if this is an OMAP3 requirement why not add it there?
-- 
Regards,
Nishanth Menon