* [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs
@ 2010-01-08 17:58 Anuj Aggarwal
2010-01-11 11:22 ` Mark Brown
2010-01-11 11:38 ` Mike Rapoport
0 siblings, 2 replies; 3+ messages in thread
From: Anuj Aggarwal @ 2010-01-08 17:58 UTC (permalink / raw)
To: linux-omap; +Cc: broonie, lrg, Anuj Aggarwal
Kconfig is modified for OMAP3 EVM so that user can choose the appropriate
PMIC (currently only TWL4030). Config options for other PMICs will be
added later on.
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
arch/arm/mach-omap2/Kconfig | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 606bf04..95b8eb2 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -82,6 +82,15 @@ config MACH_OMAP3EVM
depends on ARCH_OMAP3 && ARCH_OMAP34XX
select OMAP_PACKAGE_CBB
+config PMIC_TWL4030
+ bool "TWL4030/TPS65950 Power Module"
+ default y
+ depends on TWL4030_CORE && MACH_OMAP3EVM
+ select REGULATOR_TWL4030 if REGULATOR
+ help
+ Say yes here if you are using the TWL4030/TPS65950 based power module
+ for the EVM boards.
+
config MACH_OMAP3517EVM
bool "OMAP3517/ AM3517 EVM board"
depends on ARCH_OMAP3 && ARCH_OMAP34XX
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs
2010-01-08 17:58 [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs Anuj Aggarwal
@ 2010-01-11 11:22 ` Mark Brown
2010-01-11 11:38 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-01-11 11:22 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: linux-omap, lrg
On Fri, Jan 08, 2010 at 11:28:06PM +0530, Anuj Aggarwal wrote:
> +config PMIC_TWL4030
> + bool "TWL4030/TPS65950 Power Module"
> + default y
> + depends on TWL4030_CORE && MACH_OMAP3EVM
> + select REGULATOR_TWL4030 if REGULATOR
> + help
> + Say yes here if you are using the TWL4030/TPS65950 based power module
> + for the EVM boards.
> +
Perhaps this should select the TWL4030 driver rather than depending on
it? Configuration variables that require selection over different menus
can be a bit obscure for users since (in this case) they need to know to
go to the MFD menu, enable the TWL4030 then go back down into the OMAP
menu to enable the board-specific support.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs
2010-01-08 17:58 [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs Anuj Aggarwal
2010-01-11 11:22 ` Mark Brown
@ 2010-01-11 11:38 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2010-01-11 11:38 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: linux-omap, broonie, lrg
Anuj Aggarwal wrote:
> Kconfig is modified for OMAP3 EVM so that user can choose the appropriate
> PMIC (currently only TWL4030). Config options for other PMICs will be
> added later on.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> arch/arm/mach-omap2/Kconfig | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 606bf04..95b8eb2 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -82,6 +82,15 @@ config MACH_OMAP3EVM
> depends on ARCH_OMAP3 && ARCH_OMAP34XX
> select OMAP_PACKAGE_CBB
>
> +config PMIC_TWL4030
> + bool "TWL4030/TPS65950 Power Module"
> + default y
> + depends on TWL4030_CORE && MACH_OMAP3EVM
I don't think PMIC_TWL4030 should depend on MACH_OMAP3EVM
> + select REGULATOR_TWL4030 if REGULATOR
> + help
> + Say yes here if you are using the TWL4030/TPS65950 based power module
> + for the EVM boards.
> +
> config MACH_OMAP3517EVM
> bool "OMAP3517/ AM3517 EVM board"
> depends on ARCH_OMAP3 && ARCH_OMAP34XX
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-11 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 17:58 [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs Anuj Aggarwal
2010-01-11 11:22 ` Mark Brown
2010-01-11 11:38 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox