Re: [PATCH 4/6] Regulator: Modifying Kconfig to choose from the available PMICs

Mike Rapoport
2010-01-11T11:38:33Z

Anuj Aggarwal wrote:
> Kconfig is modified for OMAP3 EVM so that user can choose the appropriate
> PMIC (currently only TWL4030). Config options for other PMICs will be
> added later on.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> arch/arm/mach-omap2/Kconfig | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 606bf04..95b8eb2 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -82,6 +82,15 @@ config MACH_OMAP3EVM
> depends on ARCH_OMAP3 && ARCH_OMAP34XX
> select OMAP_PACKAGE_CBB
>
> +config PMIC_TWL4030
> + bool "TWL4030/TPS65950 Power Module"
> + default y
> + depends on TWL4030_CORE && MACH_OMAP3EVM

I don't think PMIC_TWL4030 should depend on MACH_OMAP3EVM

> + select REGULATOR_TWL4030 if REGULATOR
> + help
> + Say yes here if you are using the TWL4030/TPS65950 based power module
> + for the EVM boards.
> +
> config MACH_OMAP3517EVM
> bool "OMAP3517/ AM3517 EVM board"
> depends on ARCH_OMAP3 && ARCH_OMAP34XX

--
Sincerely yours,
Mike.