* [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file
@ 2010-01-08 17:58 Anuj Aggarwal
2010-01-11 11:43 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Anuj Aggarwal @ 2010-01-08 17:58 UTC (permalink / raw)
To: linux-omap; +Cc: broonie, lrg, Anuj Aggarwal
Makefile is modified so that board-omap35x-twl4030-pmic.c gets compiled
for the platforms having TWL4030 as the PMIC.
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
arch/arm/mach-omap2/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index b32678b..181be39 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -107,6 +107,7 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
mmc-twl4030.o
obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
mmc-twl4030.o
+obj-$(CONFIG_PMIC_TWL4030) += board-omap35x-twl4030-pmic.o
obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
--
1.6.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file
2010-01-08 17:58 [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file Anuj Aggarwal
@ 2010-01-11 11:43 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2010-01-11 11:43 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: linux-omap, broonie, lrg
Anuj Aggarwal wrote:
> Makefile is modified so that board-omap35x-twl4030-pmic.c gets compiled
> for the platforms having TWL4030 as the PMIC.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> arch/arm/mach-omap2/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Can you combine this patch with "Modifying Kconfig to choose from the
available PMICs" patch?
Moreover, I think the patches should be reordered so that kernel build
won't be broken. Maybe something like:
1 - Creating TWL4030 specific file having supplies & init data
2 - Modifying Kconfig and Makefile to choose from the available PMICs
3 - Kconfig modified to select TWL4030 for OMAP3 based platforms
4 - Use common regulator supplies and init data structs
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index b32678b..181be39 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -107,6 +107,7 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
> mmc-twl4030.o
> obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
> mmc-twl4030.o
> +obj-$(CONFIG_PMIC_TWL4030) += board-omap35x-twl4030-pmic.o
> obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
>
> obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-11 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 17:58 [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file Anuj Aggarwal
2010-01-11 11:43 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox