Re: [PM-WIP-OPP][PATCH] OPP: Introduces enum for addressing different OPP types

Kevin Hilman
2010-01-12T19:26:27Z

"Cousson, Benoit" <b-cousson@ti.com> writes:

> Hi Kevin,
>
>>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>>owner@vger.kernel.org] On Behalf Of Kevin Hilman
>>Sent: Tuesday, January 12, 2010 6:19 PM
>>To: Dasgupta, Romit
>>Cc: Menon, Nishanth; linux-omap@vger.kernel.org
>>Subject: Re: [PM-WIP-OPP][PATCH] OPP: Introduces enum for addressing
>>different OPP types
>>
>>Romit Dasgupta <romit@ti.com> writes:
>>
>>> Introduces enum for identifying OPP types. This helps in querying the OPP
>>> layer by passing the type of OPP (enum types) and gets away from
>>maintaining
>>> the pointer to the OPP data list outside the OPP layer.
>>>
>>> Signed-off-by: Romit Dasgupta <romit@ti.com>
>>
>>I like this idea... but I have some questions about how we should
>>cleanly handle SMP and future SoCs.
>
> Well, it is better than what we have today, but maybe not super
> scalable for next device. This information is completely device
> dependant and should not be in a plat-omap file. In that case, it
> will be tricky to have an enum per devices because it will prevent
> multiple omap build. That for that reason that I think we might use
> hwmod to identify the relevant scalable IPs, instead of yet another
> identifier for something that is IP related.

OK. Let's take this approach for now, and after hwmods get
stabilized/merged we can consider alternate per-SoC ways to handle
this.

Thanks,

Kevin