public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Philip Balister <philip@balister.org>
To: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Enabling spidev in MCSPI1
Date: Wed, 13 Jan 2010 08:00:43 -0500	[thread overview]
Message-ID: <4B4DC3FB.3020702@balister.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

I'm trying to enable spidev on mcspi1, but when I do, the kernel while 
booting after the kernel is uncompressed. No useful messages are 
displayed. This is with a current git.

I've attached the diff I use to add the spi driver to the board file. 
(OVero + Summit).

With the #if 0 inplace the kernel boots, enable that code and it fails.

+#if 0
+       spi_register_board_info(overo_mcspi_board_info,
+               ARRAY_SIZE(overo_mcspi_board_info));
+#endif

Does anyone see anything obviously wrong with what I am doing?

Philip

[-- Attachment #2: spidev.diff --]
[-- Type: text/plain, Size: 1237 bytes --]

diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index d192dd9..804d88f 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -33,6 +33,8 @@
 #include <linux/mtd/nand.h>
 #include <linux/mtd/partitions.h>
 
+#include <linux/spi/spi.h>
+
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/flash.h>
@@ -184,6 +186,16 @@ static inline void __init overo_init_smsc911x(void)
 static inline void __init overo_init_smsc911x(void) { return; }
 #endif
 
+static struct spi_board_info overo_mcspi_board_info[] = {
+	{
+		.modalias	= "spidev",
+		.max_speed_hz	= 12000000, // 12 MHz
+		.bus_num	= 1,
+		.chip_select	= 0,
+		.mode		= SPI_MODE_1,
+	},
+};
+
 static struct mtd_partition overo_nand_partitions[] = {
 	{
 		.name           = "xloader",
@@ -424,7 +436,10 @@ static void __init overo_init(void)
 	usb_ehci_init(&ehci_pdata);
 	overo_ads7846_init();
 	overo_init_smsc911x();
-
+#if 0
+	spi_register_board_info(overo_mcspi_board_info,
+		ARRAY_SIZE(overo_mcspi_board_info));
+#endif
 	/* Ensure SDRC pins are mux'd for self-refresh */
 	omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);
 	omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT);

             reply	other threads:[~2010-01-13 13:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 13:00 Philip Balister [this message]
2010-01-13 13:33 ` Enabling spidev in MCSPI1 Hemanth V
2010-01-13 20:36 ` Paul Walmsley
2010-01-15 13:43   ` Philip Balister

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4DC3FB.3020702@balister.org \
    --to=philip@balister.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox