public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <menon.nishanth@gmail.com>
To: Eduardo Valentin <eduardo.valentin@nokia.com>
Cc: ext Kevin Hilman <khilman@deeprootsystems.com>,
	Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table
Date: Tue, 19 Jan 2010 06:01:32 -0600	[thread overview]
Message-ID: <4B559F1C.6070802@gmail.com> (raw)
In-Reply-To: <1263902254-3015-1-git-send-email-eduardo.valentin@nokia.com>

Eduardo Valentin said the following on 01/19/2010 05:57 AM:
> From: Eduardo Valentin <eduardo.valentin@nokia.com>
>
> This patch removes the compilation error when compiling
> kernel with CONFIG_PM=N. The problem was that omap3_pm_init_opp_table
> was not defined if CONFIG_PM=N.
>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> ---
>  arch/arm/mach-omap2/pm.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index d257225..5fc056f 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -69,7 +69,13 @@ static inline void omap3_pm_init_vc(struct prm_setup_vc *setup_vc)
>   * Initialize the basic opp table here, board files could choose to modify opp
>   * table after the basic initialization
>   */
> +#ifdef CONFIG_PM
>  extern void omap3_pm_init_opp_table(void);
> +#else
> +static inline void omap3_pm_init_opp_table(void)
> +{
> +}
> +#endif
>  
>  extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
>  extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
>   
Err... NAK.. I think you missed 
http://marc.info/?t=126356119700001&r=1&w=2 ?
there seems to be an issue else where, I have not dug at it yet..
Regards,
Nishanth Menon

  reply	other threads:[~2010-01-19 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 11:57 [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table Eduardo Valentin
2010-01-19 12:01 ` Nishanth Menon [this message]
2010-01-19 13:49   ` Eduardo Valentin
2010-01-19 14:09     ` Romit Dasgupta
2010-01-19 14:32       ` Nishanth Menon
2010-01-19 14:41         ` Romit Dasgupta
2010-01-19 14:42           ` Nishanth Menon
2010-01-19 14:43             ` Romit Dasgupta
2010-01-19 14:45               ` Nishanth Menon
2010-01-19 14:50                 ` Romit Dasgupta
2010-01-19 15:15                   ` Nishanth Menon
2010-01-19 17:02                     ` Dasgupta, Romit
2010-01-19 15:35                   ` Cousson, Benoit
2010-01-19 17:00                     ` Dasgupta, Romit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B559F1C.6070802@gmail.com \
    --to=menon.nishanth@gmail.com \
    --cc=eduardo.valentin@nokia.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox