From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romit Dasgupta Subject: Re: [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table Date: Tue, 19 Jan 2010 19:39:23 +0530 Message-ID: <4B55BD13.70704@ti.com> References: <1263902254-3015-1-git-send-email-eduardo.valentin@nokia.com> <4B559F1C.6070802@gmail.com> <20100119134927.GE12231@esdhcp037198.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:52979 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199Ab0ASOJe (ORCPT ); Tue, 19 Jan 2010 09:09:34 -0500 In-Reply-To: <20100119134927.GE12231@esdhcp037198.research.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "eduardo.valentin@nokia.com" Cc: ext Nishanth Menon , ext Kevin Hilman , Linux-OMAP >>> >> Err... NAK.. I think you missed >> http://marc.info/?t=126356119700001&r=1&w=2 ? >> there seems to be an issue else where, I have not dug at it yet.. > > > Yeah. OK, I couldn't see the logs as the dumps has been removed already from that thread. > But if I got the problem correctly, the problem is when CONFIG_PM is not set but cpu freq is. > And if there is any call to new omap opp layer helper functions, then it will BUG the system. > Causing hangs. > > I guess one way to solve this is to bind compilation of omap opp layer to CONFIG_PM and CONFIG_CPU_FREQ. > If either is disabled, then omap opp layer must be nops. > > What do you think? > > I am sending a patch to do the above. No. That is incorrect. CONFIG_CPU_FREQ, CONFIG_CPU_IDLE and CONFIG_PM are independent. None of the features should be dependent on the other two! -Romit