From: Romit Dasgupta <romit@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: "eduardo.valentin@nokia.com" <eduardo.valentin@nokia.com>,
ext Nishanth Menon <menon.nishanth@gmail.com>,
ext Kevin Hilman <khilman@deeprootsystems.com>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table
Date: Tue, 19 Jan 2010 20:20:39 +0530 [thread overview]
Message-ID: <4B55C6BF.4080601@ti.com> (raw)
In-Reply-To: <4B55C56F.9030100@ti.com>
Menon, Nishanth wrote:
> Dasgupta, Romit had written, on 01/19/2010 08:43 AM, the following:
>>>> 3430 opps, and we should move it to opp34xx.c(I hate having new files :( )..
>>>> It should be only
>>>> #ifdef CONFIG_CPU_FREQ. OPP has nothing to do with CONFIG_PM.
>>>>
>>>> Why do you need CPU_FREQ for suspend/resume??
>>>>
>>> voltage control - SR needs to query for voltage?
>>>
>> Why should suspend/resume be dependent on SR?
> please see the code logic -> when SR is enabled and OFF/RET happens, you
> need the voltage for the current frequency so that you can disable SR,
> set the nominal voltage for the current OPP then go to WFI.
>
You do not need the OPP table for querying voltage alone. You can read that from
the OMAP chip registers directly. So OPP layer is not necessary when we do not
use cpufreq!
next prev parent reply other threads:[~2010-01-19 14:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 11:57 [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table Eduardo Valentin
2010-01-19 12:01 ` Nishanth Menon
2010-01-19 13:49 ` Eduardo Valentin
2010-01-19 14:09 ` Romit Dasgupta
2010-01-19 14:32 ` Nishanth Menon
2010-01-19 14:41 ` Romit Dasgupta
2010-01-19 14:42 ` Nishanth Menon
2010-01-19 14:43 ` Romit Dasgupta
2010-01-19 14:45 ` Nishanth Menon
2010-01-19 14:50 ` Romit Dasgupta [this message]
2010-01-19 15:15 ` Nishanth Menon
2010-01-19 17:02 ` Dasgupta, Romit
2010-01-19 15:35 ` Cousson, Benoit
2010-01-19 17:00 ` Dasgupta, Romit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B55C6BF.4080601@ti.com \
--to=romit@ti.com \
--cc=eduardo.valentin@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=menon.nishanth@gmail.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox