From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romit Dasgupta Subject: Re: [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table Date: Tue, 19 Jan 2010 20:20:39 +0530 Message-ID: <4B55C6BF.4080601@ti.com> References: <1263902254-3015-1-git-send-email-eduardo.valentin@nokia.com> <4B559F1C.6070802@gmail.com> <20100119134927.GE12231@esdhcp037198.research.nokia.com> <4B55BD13.70704@ti.com> <4B55C290.2060205@ti.com> <4B55C47E.2090002@ti.com> <4B55C4CF.4030509@ti.com> <4B55C521.5050602@ti.com> <4B55C56F.9030100@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:51065 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753911Ab0ASOut (ORCPT ); Tue, 19 Jan 2010 09:50:49 -0500 In-Reply-To: <4B55C56F.9030100@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Menon, Nishanth" Cc: "eduardo.valentin@nokia.com" , ext Nishanth Menon , ext Kevin Hilman , Linux-OMAP Menon, Nishanth wrote: > Dasgupta, Romit had written, on 01/19/2010 08:43 AM, the following: >>>> 3430 opps, and we should move it to opp34xx.c(I hate having new files :( ).. >>>> It should be only >>>> #ifdef CONFIG_CPU_FREQ. OPP has nothing to do with CONFIG_PM. >>>> >>>> Why do you need CPU_FREQ for suspend/resume?? >>>> >>> voltage control - SR needs to query for voltage? >>> >> Why should suspend/resume be dependent on SR? > please see the code logic -> when SR is enabled and OFF/RET happens, you > need the voltage for the current frequency so that you can disable SR, > set the nominal voltage for the current OPP then go to WFI. > You do not need the OPP table for querying voltage alone. You can read that from the OMAP chip registers directly. So OPP layer is not necessary when we do not use cpufreq!