Re: [PATCHv3 1/1] OMAP3: PM: move omap opp layer from pm34xx.c

Romit Dasgupta
2010-01-20T12:44:44Z

Eduardo Valentin wrote:
> On Wed, Jan 20, 2010 at 01:00:05PM +0100, ext Romit Dasgupta wrote:
>> Eduardo Valentin wrote:
>>> On Wed, Jan 20, 2010 at 12:14:59PM +0100, ext Romit Dasgupta wrote:
>>>>> From: Eduardo Valentin <eduardo.valentin@nokia.com>
>>>>>
>>>>> OMAP OPP layer functions now have dependencies of CONFIG_CPU_FREQ only.
>>>>>
>>>>> With this patch, omap opp layer now has its compilation flags
>>>>> bound to CONFIG_CPU_FREQ. Also its code has been removed from pm34xx.c.
>>>>>
>>>>> A new file has been created to contain cpu freq code related to
>>>>> OMAP3: cpufreq34xx.c.
>>>>>
>>>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
>>>> NAK also for the following non-working kernel (smartreflex without cpufreq).
>>> Then this is a problem of dependency with smartreflex and cpufreq. In this case
>>> better to solve this other problem with another patch. This patch is to rip off
>>> cpufreq code from pm34xx, as stated in the above description.
>> In that case the right fix should
>
> OK
>
>> 1) __not__ include opp.h for non cpufreq builds
>
> I guess the patch is "more or less" this option, as it maps
> all functions inside opp.h to nops if it is a cpufreq build.
> And all related real code is not compiled.
>
> Basically removes the opp layer code if cpufreq is disabled.
>
IMHO, making functions return 0 will give you run time issues when opp related
APIs are called in non cpufreq path. So your patch will for the time being solve
the build issue but not runtime issue. Hence I suggested to compile out opp.h if
you are not using cpufreq. Solving a build issue is not the right fix for this.