Re: [PATCH 1/2] DSPBRIDGE: remove dependency of mpu freq

[Nishanth Menon <nm@ti.com>]

Dasgupta, Romit had written, on 01/21/2010 01:45 AM, the following:
>> @@ -67,6 +92,9 @@ module_init(dspbridge_init);
>>  
>>  static void __exit dspbridge_exit(void)
>>  {
>> +	struct dspbridge_platform_data *pdata = &dspbridge_pdata;
>> +	kfree(pdata->mpu_speeds);
>> +	kfree(pdata->dsp_freq_table);
>>  	platform_device_unregister(dspbridge_pdev);
>>  }
>>  module_exit(dspbridge_exit);
> 
> Ok if pdata->mpu_speeds, pdata->dsp_freq_table are NULL to start with, then you
> need to make them NULL after kfree as well. Otherwise next time you insert the
> module it may fail if pdata_mpu_speeds is initialized but pdata->dsp_freq_table
> is not.
Good catch. thanks.

-- 
Regards,
Nishanth Menon