From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Ameya Palande <ameya.palande@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"omap.ramirez@ti.com" <omap.ramirez@ti.com>,
"Menon, Nishanth" <nm@ti.com>,
"Chitriki Rudramuni, Deepak" <deepak.chitriki@ti.com>
Subject: Re: [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()
Date: Mon, 25 Jan 2010 13:21:33 -0600 [thread overview]
Message-ID: <4B5DEF3D.4080701@ti.com> (raw)
In-Reply-To: <1264078990-4829-1-git-send-email-ameya.palande@nokia.com>
Hi,
On 1/21/2010 7:03 AM, Ameya Palande wrote:
> Signed-off-by: Ameya Palande<ameya.palande@nokia.com>
> ---
> drivers/dsp/bridge/rmgr/proc.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c
> index a75b64a..91ab64f 100644
> --- a/drivers/dsp/bridge/rmgr/proc.c
> +++ b/drivers/dsp/bridge/rmgr/proc.c
> @@ -512,6 +512,10 @@ DSP_STATUS PROC_AutoStart(struct CFG_DEVNODE *hDevNode,
> "No Exec file found \n");
> }
> func_cont:
> + if (hProcObject->g_pszLastCoff) {
> + MEM_Free(hProcObject->g_pszLastCoff);
> + hProcObject->g_pszLastCoff = NULL;
> + }
Wouldn't be better to keep this inside PROC_Load in case of error?
Also MEM_Free checks for NULL.
> MEM_FreeObject(hProcObject);
> func_end:
> GT_1trace(PROC_DebugMask, GT_ENTER,
Regards,
Omar
next prev parent reply other threads:[~2010-01-25 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 13:03 [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart() Ameya Palande
2010-01-25 19:21 ` Omar Ramirez Luna [this message]
2010-02-01 17:31 ` Ameya Palande
2010-02-01 17:36 ` [PATCHv2] " Ameya Palande
2010-02-06 1:57 ` Omar Ramirez Luna
2010-02-06 0:58 ` [PATCH] " Omar Ramirez Luna
-- strict thread matches above, loose matches on Subject: below --
2009-09-02 18:59 Ameya Palande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5DEF3D.4080701@ti.com \
--to=omar.ramirez@ti.com \
--cc=ameya.palande@nokia.com \
--cc=deepak.chitriki@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=omap.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox