Re: [PATCH] omap3: pm: cpufreq: populate l3 opp1 again

Romit Dasgupta
2010-01-28T06:56:06Z

Menon, Nishanth wrote:
> We had removed the frequency for OPP1 L3 when we used to use frequency
> to enable/disable frequencies. It is better to populate the same
> instead of confusing future readers of the code. The OPP1 remains
> disabled as explained in the discussion.

IMHO the best way to unconfuse readers is to remove the entry.
>
> Discussion: http://marc.info/?t=126453821900001&r=1&w=2
>
> Cc: Andrew Murray <amurray@mpc-data.co.uk>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/mach-omap2/cpufreq34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpufreq34xx.c b/arch/arm/mach-omap2/cpufreq34xx.c
> index 209af2b..aec1ffe 100644
> --- a/arch/arm/mach-omap2/cpufreq34xx.c
> +++ b/arch/arm/mach-omap2/cpufreq34xx.c
> @@ -43,7 +43,7 @@ static struct omap_opp_def __initdata omap34xx_mpu_rate_table[] = {
>
> static struct omap_opp_def __initdata omap34xx_l3_rate_table[] = {
> /* OPP1 */
> - OMAP_OPP_DEF(false, 0, 975000),
> + OMAP_OPP_DEF(false, 41500000, 975000),
> /* OPP2 */
> OMAP_OPP_DEF(true, 83000000, 1050000),
> /* OPP3 */