RE: [PATCH] omap3: pm: cpufreq: populate l3 opp1 again

Andrew Murray
2010-01-28T14:00:21Z

> From: Cousson, Benoit [mailto:b-cousson@ti.com]
> Sent: 28 January 2010 13:48
> To: Dasgupta, Romit; Menon, Nishanth
> Cc: linux-omap; Andrew Murray; Kevin Hilman
> Subject: RE: [PATCH] omap3: pm: cpufreq: populate l3 opp1 again

> I don't want to keep it. I just want to document it in order to
explain
> why the code is not aligned with the public doc.
>
> Andrew did ask the question so the answer might be useful for others
as
> well, hence a small comment on top of the CORE OPP list.
>
> Benoit

I agree.

I don't think it matters if the OPP 'OMAP_OPP_DEF' is there or not.
Though as the OPPs differ to the hardware descriptions it should be
documented - perhaps as suggested, by a comment.

It is confusing when validating the power management software support -
and the best place to look for the rationale is in the code.

Andrew Murray