From: Romit Dasgupta <romit@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Andrew Murray <amurray@mpc-data.co.uk>,
"Cousson, Benoit" <b-cousson@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] omap3: pm: cpufreq: populate l3 opp1 again
Date: Thu, 28 Jan 2010 12:25:39 +0530 [thread overview]
Message-ID: <4B6134EB.8040202@ti.com> (raw)
In-Reply-To: <1264657260-12310-1-git-send-email-nm@ti.com>
Menon, Nishanth wrote:
> We had removed the frequency for OPP1 L3 when we used to use frequency
> to enable/disable frequencies. It is better to populate the same
> instead of confusing future readers of the code. The OPP1 remains
> disabled as explained in the discussion.
IMHO the best way to unconfuse readers is to remove the entry.
>
> Discussion: http://marc.info/?t=126453821900001&r=1&w=2
>
> Cc: Andrew Murray <amurray@mpc-data.co.uk>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/mach-omap2/cpufreq34xx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/cpufreq34xx.c b/arch/arm/mach-omap2/cpufreq34xx.c
> index 209af2b..aec1ffe 100644
> --- a/arch/arm/mach-omap2/cpufreq34xx.c
> +++ b/arch/arm/mach-omap2/cpufreq34xx.c
> @@ -43,7 +43,7 @@ static struct omap_opp_def __initdata omap34xx_mpu_rate_table[] = {
>
> static struct omap_opp_def __initdata omap34xx_l3_rate_table[] = {
> /* OPP1 */
> - OMAP_OPP_DEF(false, 0, 975000),
> + OMAP_OPP_DEF(false, 41500000, 975000),
> /* OPP2 */
> OMAP_OPP_DEF(true, 83000000, 1050000),
> /* OPP3 */
next prev parent reply other threads:[~2010-01-28 6:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 5:41 [PATCH] omap3: pm: cpufreq: populate l3 opp1 again Nishanth Menon
2010-01-28 5:42 ` Nishanth Menon
2010-01-28 6:55 ` Romit Dasgupta [this message]
2010-01-28 13:24 ` Cousson, Benoit
2010-01-28 13:43 ` Dasgupta, Romit
2010-01-28 13:47 ` Cousson, Benoit
2010-01-28 14:00 ` Andrew Murray
2010-01-28 15:18 ` Nishanth Menon
2010-01-28 17:23 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6134EB.8040202@ti.com \
--to=romit@ti.com \
--cc=amurray@mpc-data.co.uk \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox