From mboxrd@z Thu Jan 1 00:00:00 1970 From: Romit Dasgupta Subject: Re: [PATCH] omap3: pm: cpufreq: populate l3 opp1 again Date: Thu, 28 Jan 2010 12:25:39 +0530 Message-ID: <4B6134EB.8040202@ti.com> References: <1264657260-12310-1-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:41416 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754861Ab0A1G4G (ORCPT ); Thu, 28 Jan 2010 01:56:06 -0500 In-Reply-To: <1264657260-12310-1-git-send-email-nm@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Menon, Nishanth" Cc: linux-omap , Andrew Murray , "Cousson, Benoit" , Kevin Hilman Menon, Nishanth wrote: > We had removed the frequency for OPP1 L3 when we used to use frequency > to enable/disable frequencies. It is better to populate the same > instead of confusing future readers of the code. The OPP1 remains > disabled as explained in the discussion. IMHO the best way to unconfuse readers is to remove the entry. > > Discussion: http://marc.info/?t=126453821900001&r=1&w=2 > > Cc: Andrew Murray > Cc: Benoit Cousson > Cc: Kevin Hilman > > Signed-off-by: Nishanth Menon > --- > arch/arm/mach-omap2/cpufreq34xx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/cpufreq34xx.c b/arch/arm/mach-omap2/cpufreq34xx.c > index 209af2b..aec1ffe 100644 > --- a/arch/arm/mach-omap2/cpufreq34xx.c > +++ b/arch/arm/mach-omap2/cpufreq34xx.c > @@ -43,7 +43,7 @@ static struct omap_opp_def __initdata omap34xx_mpu_rate_table[] = { > > static struct omap_opp_def __initdata omap34xx_l3_rate_table[] = { > /* OPP1 */ > - OMAP_OPP_DEF(false, 0, 975000), > + OMAP_OPP_DEF(false, 41500000, 975000), > /* OPP2 */ > OMAP_OPP_DEF(true, 83000000, 1050000), > /* OPP3 */