public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: "Gomez Castellanos, Ivan" <ivan.gomez@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Ameya.Palande@nokia.com" <Ameya.Palande@nokia.com>,
	"Hiroshi.DOYU@nokia.com" <Hiroshi.DOYU@nokia.com>,
	"felipe.contreras@nokia.com" <felipe.contreras@nokia.com>,
	"Menon, Nishanth" <nm@ti.com>
Subject: Re: [PATCH v2 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function
Date: Tue, 2 Feb 2010 13:19:45 -0600	[thread overview]
Message-ID: <4B687AD1.10903@ti.com> (raw)
In-Reply-To: <818EF96F5A7CC84789DD014773DB095484859F64@dlee01.ent.ti.com>

On 1/28/2010 7:18 PM, Gomez Castellanos, Ivan wrote:
> In the previous patch, the function prototype was not removed.
>
>  From 22a3646710806c9390a48556ded889e19178db9e Mon Sep 17 00:00:00 2001
> From: Ivan Gomez<ivan.gomez@ti.com>
> Date: Thu, 28 Jan 2010 18:53:45 -0600
> Subject: [PATCH] DSPBRIDGE: Remove DRV_ProcUpdatestate function
>
> The DRV_ProcUpdatestate function was only used in two places and
> it only assigned a value.
>
> Signed-off-by: Ivan Gomez<ivan.gomez@ti.com>
> ---

[...]

> diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c
> index f3a67e2..09365bc 100644
> --- a/drivers/dsp/bridge/rmgr/drv_interface.c
> +++ b/drivers/dsp/bridge/rmgr/drv_interface.c
> @@ -503,7 +503,7 @@ static int bridge_open(struct inode *ip, struct file *filp)
>   	 */
>   	pr_ctxt = MEM_Calloc(sizeof(struct PROCESS_CONTEXT), MEM_PAGED);
>   	if (pr_ctxt)
> -		DRV_ProcUpdatestate(pr_ctxt, PROC_RES_ALLOCATED);
> +		pr_ctxt->resSatate = PROC_RES_ALLOCATED;

should be resState

>   	else
>   		status = -ENOMEM;
>
> @@ -622,7 +622,7 @@ DSP_STATUS DRV_RemoveAllResources(HANDLE hPCtxt)
>   	DRV_RemoveAllSTRMResElements(pCtxt);
>   	DRV_RemoveAllNodeResElements(pCtxt);
>   	DRV_RemoveAllDMMResElements(pCtxt);
> -	DRV_ProcUpdatestate(pCtxt, PROC_RES_FREED);
> +	pCtxt->resState = PROC_RES_FREED;
>   	return status;
>   }
>   #endif


      reply	other threads:[~2010-02-02 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29  1:18 [PATCH v2 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function Gomez Castellanos, Ivan
2010-02-02 19:19 ` Omar Ramirez Luna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B687AD1.10903@ti.com \
    --to=omar.ramirez@ti.com \
    --cc=Ameya.Palande@nokia.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=felipe.contreras@nokia.com \
    --cc=ivan.gomez@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox