From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Ameya Palande <ameya.palande@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Menon, Nishanth" <nm@ti.com>,
"Chitriki Rudramuni, Deepak" <deepak.chitriki@ti.com>
Subject: Re: [PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree()
Date: Mon, 8 Feb 2010 16:47:59 -0600 [thread overview]
Message-ID: <4B70949F.20306@ti.com> (raw)
In-Reply-To: <ad25763f4a3358893208d591f5a055ac6f8c85ea.1265296743.git.ameya.palande@nokia.com>
On 2/4/2010 9:33 AM, Ameya Palande wrote:
> vfree() is NULL safe so MEM_VFree() doesn't provide any significant
> advantage. By getting rid of MEM_VFree() and the NULL pointer check
> associated with it, we can save on:
> 1. One level of indirection which translates to a function call cost.
> 2. NULL pointer checking cost.
>
> Signed-off-by: Ameya Palande<ameya.palande@nokia.com>
> ---
> arch/arm/plat-omap/include/dspbridge/mem.h | 17 -----------------
> drivers/dsp/bridge/pmgr/dmm.c | 3 +--
> drivers/dsp/bridge/services/mem.c | 17 -----------------
> 3 files changed, 1 insertions(+), 36 deletions(-)
>
Acked-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Pushed to dspbridge.
- omar
next prev parent reply other threads:[~2010-02-08 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 15:33 [PATCHv2 0/3] DSPBRIDGE: MEM Module cleanup series Ameya Palande
2010-02-04 15:33 ` [PATCH 1/3] DSPBRIDGE: Get rid of MEM_CHECK mechanism Ameya Palande
2010-02-08 22:47 ` Omar Ramirez Luna
2010-02-04 15:33 ` [PATCH 2/3] DSPBRIDGE: Get rid of MEM_Free() Ameya Palande
2010-02-06 1:58 ` Omar Ramirez Luna
2010-02-06 15:16 ` ameya.palande
2010-02-08 22:47 ` Omar Ramirez Luna
2010-02-04 15:33 ` [PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree() Ameya Palande
2010-02-08 22:47 ` Omar Ramirez Luna [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-03 23:32 [PATCH 0/3] DSPBRIDGE: MEM Module cleanup series Ameya Palande
2010-02-03 23:32 ` [PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree() Ameya Palande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B70949F.20306@ti.com \
--to=omar.ramirez@ti.com \
--cc=ameya.palande@nokia.com \
--cc=deepak.chitriki@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox