From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 12/19] OMAP3 clock: Remove FreqSel for 3630 Date: Tue, 16 Feb 2010 14:00:07 +0300 Message-ID: <4B7A7AB7.90503@ru.mvista.com> References: <20100216011942.1101.14348.stgit@localhost.localdomain> <20100216012453.1101.96664.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f219.google.com ([209.85.219.219]:60704 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923Ab0BPLAh (ORCPT ); Tue, 16 Feb 2010 06:00:37 -0500 Received: by ewy19 with SMTP id 19so4157853ewy.21 for ; Tue, 16 Feb 2010 03:00:35 -0800 (PST) In-Reply-To: <20100216012453.1101.96664.stgit@localhost.localdomain> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vishwanath BS Hello. Paul Walmsley wrote: > From: Vishwanath BS > > DPLL_FREQSEL field in CLKEN_PLL register is no longer valid for > OMAP3630. So remove references to that. > > Signed-off-by: Vishwanath BS > Signed-off-by: Paul Walmsley > --- > arch/arm/mach-omap2/dpll3xxx.c | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c > index 2b559fc..84be81c 100644 > --- a/arch/arm/mach-omap2/dpll3xxx.c > +++ b/arch/arm/mach-omap2/dpll3xxx.c > @@ -243,8 +243,11 @@ static int omap3_noncore_dpll_program(struct clk *clk, u16 m, u8 n, u16 freqsel) > /* 3430 ES2 TRM: 4.7.6.9 DPLL Programming Sequence */ > _omap3_noncore_dpll_bypass(clk); > > - /* Set jitter correction */ > - if (!cpu_is_omap44xx()) { > + /* > + * Set jitter correction. No jitter correction for OMAP4 and 3630 > + * since freqsel is field is no longer present > I can't parse that comment. I guess first "is" is not needed. :-) WBR, Sergei