From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCH] dspbridge: Simplify Atoi() method (v2)
Date: Tue, 16 Feb 2010 17:49:04 -0600 [thread overview]
Message-ID: <4B7B2EF0.80002@ti.com> (raw)
In-Reply-To: <1265788738-27123-1-git-send-email-andy.shevchenko@gmail.com>
On 2/10/2010 1:58 AM, Andy Shevchenko wrote:
> From: Andy Shevchenko<ext-andriy.shevchenko@nokia.com>
>
> Try to use simple_strtoul() kernel native method instead.
>
> However, there are opened questions:
> - why type of Atoi() is s32 if the sign is used only to detect base?
> - should we really to check hex integers like DEAD0123h?
> - how many spaces could lead token?
>
> Signed-off-by: Andy Shevchenko<ext-andriy.shevchenko@nokia.com>
Acked-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Pushed to dspbridge
- omar
next prev parent reply other threads:[~2010-02-16 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 10:14 [PATCH] dspbridge: Simplify Atoi() method Andy Shevchenko
2010-02-10 2:02 ` Omar Ramirez Luna
2010-02-10 7:58 ` [PATCH] dspbridge: Simplify Atoi() method (v2) Andy Shevchenko
2010-02-16 23:49 ` Omar Ramirez Luna [this message]
2010-02-10 7:59 ` [PATCH] dspbridge: Simplify Atoi() method Andy Shevchenko
2010-02-10 15:55 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7B2EF0.80002@ti.com \
--to=omar.ramirez@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox