RE: [PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource cleanup

Guzman Lugo, Fernando
2010-02-18T22:47:00Z

Hi,

>-----Original Message-----
>From: Ameya Palande [mailto:ameya.palande@nokia.com]
>Sent: Thursday, February 18, 2010 8:41 AM
>To: linux-omap@vger.kernel.org
>Cc: felipe.contreras@nokia.com; Menon, Nishanth; Chitriki Rudramuni,
>Deepak; Guzman Lugo, Fernando; Ramirez Luna, Omar
>Subject: [PATCHv5 0/4] DSPBRIDGE: Improved reserved and mapped resource
>cleanup
>
>This patch series splits DMM_RES_OBJECT into DMM_MAP_OBJECT and
>DMM_RSV_OBJECT
>which are used independently for mapped and reserved memory resources
>accounting. This will help in cleanup of reserved memory resources which
>was
>not handled properly before. With these patches resource cleanup mechanism
>will work perfectly in a use case where a big chunk of memory is reserved
>and
>then lot of mappings are created inside it.
>
>Changes since v4:
>1. Replace unnecessary list_for_each_entry_safe to list_for_each_entry
> http://marc.info/?l=linux-omap&m=126645721715598&w=2
>2. Comments at appropriate places to explain resource tracking objects
> insertion and removals.
> http://marc.info/?l=linux-omap&m=126649541624172&w=2
>
>Changes since v3:
>1. Improved mapped memory resource cleanup
>
>Changes since v2:
>1. Removed locking from DRV_RemoveAllDMMResElements()
>2. Removed cleanup variable from PROC_UnReserveMemory()
> http://marc.info/?l=linux-omap&m=126637211831587&w=2
>3. Rebased patchset on top of following commit:
> DSPBRIDGE: Remove conditional check from the InputMsg function
>
>Changed since v1:
>1. Reduced indentation
> http://marc.info/?l=linux-omap&m=126624982331523&w=2
>
>Ameya Palande (4):
> DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT
> DSPBRIDGE: New reserved memory accounting framework
> DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes
> DSPBRIDGE: Improved mapped memory cleanup
>
> arch/arm/plat-omap/include/dspbridge/drv.h | 44 ++---
> arch/arm/plat-omap/include/dspbridge/proc.h | 4 +-
> .../plat-omap/include/dspbridge/resourcecleanup.h | 11 --
> drivers/dsp/bridge/pmgr/wcd.c | 7 +-
> drivers/dsp/bridge/rmgr/drv.c | 176 +++-------------
>----
> drivers/dsp/bridge/rmgr/drv_interface.c | 5 +-
> drivers/dsp/bridge/rmgr/node.c | 5 +-
> drivers/dsp/bridge/rmgr/proc.c | 105 +++++++++---
> 8 files changed, 134 insertions(+), 223 deletions(-)

Just for the comment in "DSPBRIDGE: Improved mapped memory cleanup", now there is a comment that explain what the code does, however I still think that the resource cleanup related code should be in only one file (for example drv.h) to have a more organized code. Others things look good!

Acked-by: Fernando Guzman Lugo <x0095840@ti.com>