Re: [PM-WIP-OPP][PATCH 3/4] omap: pm: opp: add ability to store data per opp

Nishanth Menon
2010-03-19T18:11:08Z

Felipe Balbi had written, on 03/19/2010 12:47 PM, the following:
[...]

>> now in the approach I took,
>> you could have:
>> struct sr_ntarget_type{
>> unsigned long nTarget;
>> something else if needed
>> }
>>
>> And in SR driver, the module doesnot need to care which silicon it is
>> running on.. it just does opp_get_data(opp,"sr_ntarget") and gets the
>> correct data for that silicon on that OPP. It is much simpler and
>> similar to the manner implemented in many other frameworks such as clock
>> etc..
>
> the thing is that ideally it would simply:
>
> opp_get_data(opp);
>
> and that should be done so that it fits all possibilities, but if it's
> that different per-SoC, then I guess there's nothing to do.
>
but consider this:
data type1,2,3.. may have been stored w.r.t an opp.. now the module
who'd query it wants it's own data and does not care about anything
else... opp_get_data(opp) alone does not help, you'd need
opp_get_data(opp,some_identfier) :).. hence the implementation..

--
Regards,
Nishanth Menon