Re: [PATCH] AM35x: Add musb support

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Gupta, Ajay Kumar wrote:
>> -----Original Message-----
>> From: Sergei Shtylyov [mailto:sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org]
>> Sent: Monday, March 22, 2010 4:33 PM
>> To: Gupta, Ajay Kumar
>> Cc: Sergei Shtylyov; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Subject: Re: [PATCH] AM35x: Add musb support
>>
>> Gupta, Ajay Kumar wrote:
>>
>>     
>>>>>>> I have not added CPPI4.1 DMA  specific register here..
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>>    Ah. Then they're not compatible with DA8xx anyway...
>>>>>>
>>>>>>
>>>>>>             
>>>>> We could make it compatible with some change as done at,
>>>>> http://arago-project.org/git/people/?p=sriram/ti-psp-
>>>>>
>>>>>           
>>>> omap.git;a=commitdiff;h=2ecce9529bd56c32997e0b2cbe84f7727ba5b217
>>>>
>>>> I'm not sure where cppi41_dma.c gets the definitions for
>>>> USB_[RT]X_MODE_REG...
>>>>
>>>>         
>>> It is being used from plat/usb.h.
>>>
>>>       
>>    I haven't found where it's included.
>>     
>
> It's from cppi41_dma.h.
>   

   Well, you've removed the register #define's from cppi41_dma.h and 
#includ'ed <plat/usb.h> BUT there's certainly no such header for DA8xx , 
so as I  suspected you've broken DA8xx support. That certainly won't do. :-/

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html