From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Ameya Palande <ameya.palande@nokia.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Doyu Hiroshi (Nokia-D/Helsinki)" <hiroshi.doyu@nokia.com>,
Tony Lindgren <tony@atomide.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
"Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>,
"Hebbar, Shivananda" <x0hebbar@ti.com>,
"Shevchenko Andriy (EXT-Teleca/Helsinki)"
<ext-andriy.shevchenko@nokia.com>,
"Ramos Falcon, Ernesto" <ernesto@ti.com>,
"Guzman Lugo, Fernando" <x0095840@ti.com>,
"Gupta, Ramesh" <grgupta@ti.com>,
"Kukkonen Mika (Nokia-D/Helsinki)" <mika.kukkonen@nokia.com>,
"Kanigeri, Hari" <h-kanigeri2@ti.com>,
"Menon, Nishanth" <nm@ti.com>,
"C.A, Subramaniam" <subramaniam.ca@ti.com>,
Rebecca Schultz Zavin <rebecca@android.com>,
"Carmody Phil.2 (EXT-Ixonos/Helsinki)"
<ext-phil.2.carmody@nokia.com>
Subject: Re: [dspbridge] news: omap mailbox implementation
Date: Tue, 23 Mar 2010 13:29:07 -0500 [thread overview]
Message-ID: <4BA90873.1000100@ti.com> (raw)
In-Reply-To: <1269366889.2126.2.camel@sanganak>
On 3/23/2010 12:54 PM, Ameya Palande wrote:
> Hi Omar,
>
> On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
>> Hi All,
>>
>> When updating the custom dspbridge mailbox functions with the ones
>> avaliable through omap mailbox (by pulling latest dspbridge),
>> PLEASE remember to enable omap mailbox through menuconfig:
>>
>> make menuconfig
>>
>> System Type --->
>> TI OMAP Implementations --->
>> <*> Mailbox framework support
>>
>> otherwise, compilation will break like:
>>
>> Building modules, stage 2.
>> MODPOST 7 modules
>> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> make[2]: *** [__modpost] Error 1
>> make[1]: *** [modules] Error 2
>> make: *** [modules] Error 2
>
> Can't we make DSP Bridge driver depend on mailbox then?
>
Yes we can, but I thought that new-to-bridge people who want to compile
a kernel and are impatient enough to read a wiki (updating as we speak),
would freak out if DSP Bridge is not shown in menuconfig because it is
dependent on mailbox ;). Also thought that a note in Bridge defconfig
option might be enough "This driver depends on OMAP Mailbox
(OMAP_MBOX_FWK).", rather than a hard dependency.
The other option was to update the defconfig.
I'm fine with any of those or if anyone has a better suggestion.
Regards,
Omar
next prev parent reply other threads:[~2010-03-23 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 18:08 [dspbridge] news: omap mailbox implementation Omar Ramirez Luna
2010-03-23 17:54 ` Ameya Palande
2010-03-23 18:29 ` Omar Ramirez Luna [this message]
2010-03-23 18:31 ` Ameya Palande
2010-03-23 18:42 ` Omar Ramirez Luna
2010-03-23 18:33 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA90873.1000100@ti.com \
--to=omar.ramirez@ti.com \
--cc=Tomi.Valkeinen@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=ernesto@ti.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=grgupta@ti.com \
--cc=h-kanigeri2@ti.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=mika.kukkonen@nokia.com \
--cc=nm@ti.com \
--cc=rebecca@android.com \
--cc=subramaniam.ca@ti.com \
--cc=tony@atomide.com \
--cc=x0095840@ti.com \
--cc=x0hebbar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox