From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Ramirez Luna Subject: Re: [dspbridge] news: omap mailbox implementation Date: Tue, 23 Mar 2010 13:42:20 -0500 Message-ID: <4BA90B8C.9050806@ti.com> References: <1269367702-2589-1-git-send-email-omar.ramirez@ti.com> <1269366889.2126.2.camel@sanganak> <4BA90873.1000100@ti.com> <1269369096.2126.4.camel@sanganak> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:40102 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415Ab0CWSm0 (ORCPT ); Tue, 23 Mar 2010 14:42:26 -0400 In-Reply-To: <1269369096.2126.4.camel@sanganak> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ameya Palande Cc: "linux-omap@vger.kernel.org" , "Doyu Hiroshi (Nokia-D/Helsinki)" , Tony Lindgren , Felipe Contreras , "Valkeinen Tomi (Nokia-D/Helsinki)" , "Hebbar, Shivananda" , "Shevchenko Andriy (EXT-Teleca/Helsinki)" , "Ramos Falcon, Ernesto" , "Guzman Lugo, Fernando" , "Gupta, Ramesh" , "Kukkonen Mika (Nokia-D/Helsinki)" , "Kanigeri, Hari" , "Menon, Nishanth" , "C.A, Subramaniam" , Rebecca Schultz Zavin , "Carmody Phil.2 (EXT-Ixonos/Helsinki)" On 3/23/2010 1:31 PM, Ameya Palande wrote: > On Tue, 2010-03-23 at 19:29 +0100, ext Omar Ramirez Luna wrote: >> On 3/23/2010 12:54 PM, Ameya Palande wrote: >>> Hi Omar, >>> >>> On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote: >>>> Hi All, >>>> >>>> When updating the custom dspbridge mailbox functions with the ones >>>> avaliable through omap mailbox (by pulling latest dspbridge), >>>> PLEASE remember to enable omap mailbox through menuconfig: >>>> >>>> make menuconfig >>>> >>>> System Type ---> >>>> TI OMAP Implementations ---> >>>> <*> Mailbox framework support >>>> >>>> otherwise, compilation will break like: >>>> >>>> Building modules, stage 2. >>>> MODPOST 7 modules >>>> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined! >>>> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined! >>>> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined! >>>> make[2]: *** [__modpost] Error 1 >>>> make[1]: *** [modules] Error 2 >>>> make: *** [modules] Error 2 >>> >>> Can't we make DSP Bridge driver depend on mailbox then? >>> >> >> Yes we can, but I thought that new-to-bridge people who want to compile >> a kernel and are impatient enough to read a wiki (updating as we speak), >> would freak out if DSP Bridge is not shown in menuconfig because it is >> dependent on mailbox ;). Also thought that a note in Bridge defconfig >> option might be enough "This driver depends on OMAP Mailbox >> (OMAP_MBOX_FWK).", rather than a hard dependency. > > I would go for hard dependency since otherwise we can't compile > dspbridge module :( > > IMO selecting dspbridge module should automatically select mailbox > module as well and same should apply for modprobe also :) Agree to auto select then, will send a patch to modify Kconfig. - omar