[PATCH 0/3] dspbridge: minor mbox cleanups

[PATCH 0/3] dspbridge: minor mbox cleanups

[Omar Ramirez Luna]

Fix obvious coding style issues not seen during review.

And now bridge driver will auto select mailbox driver.

Omar Ramirez Luna (3):
  DSPBRIDGE: fix checkpatch error introduced with mailbox patches
  DSPBRIDGE: Fix obvious wrong comment formats in mbox migration
  DSPBRIDGE: auto select mailbox when compiling bridge

 drivers/dsp/bridge/Kconfig          |    1 +
 drivers/dsp/bridge/wmd/_tiomap.h    |    4 ++--
 drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

[PATCH 1/3] DSPBRIDGE: fix checkpatch error introduced with mailbox patches

[Omar Ramirez Luna]

This fixes:
ERROR: "foo* bar" should be "foo *bar"
218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
+dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
 drivers/dsp/bridge/wmd/_tiomap.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dsp/bridge/wmd/_tiomap.h b/drivers/dsp/bridge/wmd/_tiomap.h
index 7a884f4..e853777 100644
--- a/drivers/dsp/bridge/wmd/_tiomap.h
+++ b/drivers/dsp/bridge/wmd/_tiomap.h
@@ -371,6 +371,6 @@ extern dsp_status wmd_tlb_dsp_va_to_mpu_pa(struct wmd_dev_context *dev_context,
  *  Requires:
  *  Ensures:
  */
-dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
+dsp_status sm_interrupt_dsp(struct wmd_dev_context *dev_context, u16 mb_val);
 
 #endif /* _TIOMAP_ */
-- 
1.6.2.4

[PATCH 2/3] DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

[Omar Ramirez Luna]

Fix obvious wrong comment formats in mbox migration.

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com
---
 drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
 drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dsp/bridge/wmd/_tiomap.h b/drivers/dsp/bridge/wmd/_tiomap.h
index e853777..71ef731 100644
--- a/drivers/dsp/bridge/wmd/_tiomap.h
+++ b/drivers/dsp/bridge/wmd/_tiomap.h
@@ -326,7 +326,7 @@ struct wmd_dev_context {
 	u32 dw_dsp_start_add;	/* API Boot vector */
 	u32 dw_internal_size;	/* Internal memory size */
 
-	struct omap_mbox *mbox;		/* Mail box handle*/
+	struct omap_mbox *mbox;		/* Mail box handle */
 
 	/*
 	 * Processor specific info is set when prog loaded and read from DCD.
diff --git a/drivers/dsp/bridge/wmd/tiomap3430.c b/drivers/dsp/bridge/wmd/tiomap3430.c
index d90518a..a972ea2 100644
--- a/drivers/dsp/bridge/wmd/tiomap3430.c
+++ b/drivers/dsp/bridge/wmd/tiomap3430.c
@@ -663,7 +663,7 @@ static dsp_status bridge_brd_start(struct wmd_dev_context *hDevContext,
 					       ul_dsp_clk_addr, sizeof(u32), 0);
 		}
 		/*
-		 *Enable Mailbox events and also drain any pending
+		 * Enable Mailbox events and also drain any pending
 		 * stale messages.
 		 */
 		dev_context->mbox = omap_mbox_get("dsp");
-- 
1.6.2.4

[PATCH 3/3] DSPBRIDGE: auto select mailbox when compiling bridge

[Omar Ramirez Luna]

Auto select mailbox when compiling bridgedriver.

If selected as module, first install:
arch/arm/plat-omap/mailbox.ko
arch/arm/mach-omap2/mailbox_mach.ko

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com
---
 drivers/dsp/bridge/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dsp/bridge/Kconfig b/drivers/dsp/bridge/Kconfig
index c721f40..a3251c3 100644
--- a/drivers/dsp/bridge/Kconfig
+++ b/drivers/dsp/bridge/Kconfig
@@ -5,6 +5,7 @@
 menuconfig MPU_BRIDGE
 	tristate "DSP Bridge driver"
 	default n
+	select OMAP_MBOX_FWK
 	help
 	  DSP/BIOS Bridge is designed for platforms that contain a GPP and
 	  one or more attached DSPs.  The GPP is considered the master or
-- 
1.6.2.4

Re: [PATCH 3/3] DSPBRIDGE: auto select mailbox when compiling bridge

[Deepak Chitriki]

Omar Ramirez Luna wrote:
> Auto select mailbox when compiling bridgedriver.
>
> If selected as module, first install:
> arch/arm/plat-omap/mailbox.ko
> arch/arm/mach-omap2/mailbox_mach.ko
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com
> ---
>  drivers/dsp/bridge/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dsp/bridge/Kconfig b/drivers/dsp/bridge/Kconfig
> index c721f40..a3251c3 100644
> --- a/drivers/dsp/bridge/Kconfig
> +++ b/drivers/dsp/bridge/Kconfig
> @@ -5,6 +5,7 @@
>  menuconfig MPU_BRIDGE
>  	tristate "DSP Bridge driver"
>  	default n
> +	select OMAP_MBOX_FWK
>  	help
>  	  DSP/BIOS Bridge is designed for platforms that contain a GPP and
>  	  one or more attached DSPs.  The GPP is considered the master or
>   
Acked-by: Deepak Chitriki <deepak.chitriki@ti.com>

Deepak

Re: [PATCH 3/3] DSPBRIDGE: auto select mailbox when compiling bridge

[Omar Ramirez Luna]

On 3/24/2010 2:12 PM, Chitriki Rudramuni, Deepak wrote:
> Omar Ramirez Luna wrote:
>> Auto select mailbox when compiling bridgedriver.
>>
>> If selected as module, first install:
>> arch/arm/plat-omap/mailbox.ko
>> arch/arm/mach-omap2/mailbox_mach.ko
>>
>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com
[...]
> Acked-by: Deepak Chitriki<deepak.chitriki@ti.com>
>

Pushed to dspbridge.

- Omar

Re: [PATCH 2/3] DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

[Deepak Chitriki]

Ramirez Luna, Omar wrote:
> Fix obvious wrong comment formats in mbox migration.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com
> ---
>  drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
>  drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dsp/bridge/wmd/_tiomap.h b/drivers/dsp/bridge/wmd/_tiomap.h
> index e853777..71ef731 100644
> --- a/drivers/dsp/bridge/wmd/_tiomap.h
> +++ b/drivers/dsp/bridge/wmd/_tiomap.h
> @@ -326,7 +326,7 @@ struct wmd_dev_context {
>  	u32 dw_dsp_start_add;	/* API Boot vector */
>  	u32 dw_internal_size;	/* Internal memory size */
>  
> -	struct omap_mbox *mbox;		/* Mail box handle*/
> +	struct omap_mbox *mbox;		/* Mail box handle */
>  
>  	/*
>  	 * Processor specific info is set when prog loaded and read from DCD.
> diff --git a/drivers/dsp/bridge/wmd/tiomap3430.c b/drivers/dsp/bridge/wmd/tiomap3430.c
> index d90518a..a972ea2 100644
> --- a/drivers/dsp/bridge/wmd/tiomap3430.c
> +++ b/drivers/dsp/bridge/wmd/tiomap3430.c
> @@ -663,7 +663,7 @@ static dsp_status bridge_brd_start(struct wmd_dev_context *hDevContext,
>  					       ul_dsp_clk_addr, sizeof(u32), 0);
>  		}
>  		/*
> -		 *Enable Mailbox events and also drain any pending
> +		 * Enable Mailbox events and also drain any pending
>  		 * stale messages.
>  		 */
>  		dev_context->mbox = omap_mbox_get("dsp");
>   
Acked-by: Deepak Chitriki <deepak.chitriki@ti.com>

Deepak

Re: [PATCH 2/3] DSPBRIDGE: Fix obvious wrong comment formats in mbox migration

[Omar Ramirez Luna]

On 3/24/2010 2:12 PM, Chitriki Rudramuni, Deepak wrote:
> Ramirez Luna, Omar wrote:
>> Fix obvious wrong comment formats in mbox migration.
>>
>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com
>> ---
>>   drivers/dsp/bridge/wmd/_tiomap.h    |    2 +-
>>   drivers/dsp/bridge/wmd/tiomap3430.c |    2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
[...]
> Acked-by: Deepak Chitriki<deepak.chitriki@ti.com>
>

Pushed to dspbridge.

- Omar

Re: [PATCH 1/3] DSPBRIDGE: fix checkpatch error introduced with mailbox patches

[Deepak Chitriki]

Omar Ramirez Luna wrote:
> This fixes:
> ERROR: "foo* bar" should be "foo *bar"
> 218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
> +dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
>  drivers/dsp/bridge/wmd/_tiomap.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dsp/bridge/wmd/_tiomap.h b/drivers/dsp/bridge/wmd/_tiomap.h
> index 7a884f4..e853777 100644
> --- a/drivers/dsp/bridge/wmd/_tiomap.h
> +++ b/drivers/dsp/bridge/wmd/_tiomap.h
> @@ -371,6 +371,6 @@ extern dsp_status wmd_tlb_dsp_va_to_mpu_pa(struct wmd_dev_context *dev_context,
>   *  Requires:
>   *  Ensures:
>   */
> -dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
> +dsp_status sm_interrupt_dsp(struct wmd_dev_context *dev_context, u16 mb_val);
>  
>  #endif /* _TIOMAP_ */
>   
Acked-by: Deepak Chitriki <deepak.chitriki@ti.com>

Deepak

Re: [PATCH 1/3] DSPBRIDGE: fix checkpatch error introduced with mailbox patches

[Omar Ramirez Luna]

On 3/24/2010 2:11 PM, Chitriki Rudramuni, Deepak wrote:
> Omar Ramirez Luna wrote:
>> This fixes:
>> ERROR: "foo* bar" should be "foo *bar"
>> 218: FILE: drivers/dsp/bridge/wmd/_tiomap.h:374:
>> +dsp_status sm_interrupt_dsp(struct wmd_dev_context* dev_context, u16 mb_val);
>>
>> Signed-off-by: Omar Ramirez Luna<omar.ramirez@ti.com>
[...]
> Acked-by: Deepak Chitriki<deepak.chitriki@ti.com>
>

Pushed to dspbridge.

- Omar