* PATCH] OMAP3: add mailbox initialization for 3630
@ 2010-03-25 22:51 Guzman Lugo, Fernando
2010-03-25 22:55 ` Kanigeri, Hari
2010-03-25 23:01 ` Deepak Chitriki
0 siblings, 2 replies; 6+ messages in thread
From: Guzman Lugo, Fernando @ 2010-03-25 22:51 UTC (permalink / raw)
To: linux-omap@vger.kernel.org
Cc: Doyu Hiroshi (Nokia-D/Helsinki), Palande Ameya (Nokia-D/Helsinki),
Felipe Contreras
>From 1fcfb230789f904de80c46b69c50879ee3f32ed8 Mon Sep 17 00:00:00 2001
From: Fernando Guzman Lugo <x0095840@ti.com>
Date: Thu, 25 Mar 2010 16:55:46 -0600
Subject: [PATCH] OMAP3: add mailbox initialization for 3630
This patch adds mailbox initialization for 3630
Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
arch/arm/mach-omap2/devices.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 18ad931..f9d177b 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -196,7 +196,8 @@ static struct platform_device mbox_device = {
static inline void omap_init_mbox(void)
{
- if (cpu_is_omap2420() || cpu_is_omap3430() || cpu_is_omap44xx()) {
+ if (cpu_is_omap2420() || cpu_is_omap3430() ||
+ cpu_is_omap3630() || cpu_is_omap44xx()) {
mbox_device.num_resources = ARRAY_SIZE(omap_mbox_resources);
mbox_device.resource = omap_mbox_resources;
} else {
--
1.6.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: PATCH] OMAP3: add mailbox initialization for 3630
2010-03-25 22:51 PATCH] OMAP3: add mailbox initialization for 3630 Guzman Lugo, Fernando
@ 2010-03-25 22:55 ` Kanigeri, Hari
2010-03-25 23:44 ` Guzman Lugo, Fernando
2010-03-25 23:01 ` Deepak Chitriki
1 sibling, 1 reply; 6+ messages in thread
From: Kanigeri, Hari @ 2010-03-25 22:55 UTC (permalink / raw)
To: Guzman Lugo, Fernando, linux-omap@vger.kernel.org
Cc: Doyu Hiroshi (Nokia-D/Helsinki), Palande Ameya (Nokia-D/Helsinki),
Felipe Contreras
Fernando,
> + if (cpu_is_omap2420() || cpu_is_omap3430() ||
> + cpu_is_omap3630() || cpu_is_omap44xx())
looks like this check is applied to all OMAPS. Can we just remove this check ?
Thank you,
Best regards,
Hari
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: PATCH] OMAP3: add mailbox initialization for 3630
2010-03-25 22:55 ` Kanigeri, Hari
@ 2010-03-25 23:44 ` Guzman Lugo, Fernando
2010-03-26 5:25 ` Hiroshi DOYU
0 siblings, 1 reply; 6+ messages in thread
From: Guzman Lugo, Fernando @ 2010-03-25 23:44 UTC (permalink / raw)
To: Kanigeri, Hari, linux-omap@vger.kernel.org
Cc: Doyu Hiroshi (Nokia-D/Helsinki), Palande Ameya (Nokia-D/Helsinki),
Felipe Contreras
>-----Original Message-----
>From: Kanigeri, Hari
>Sent: Thursday, March 25, 2010 4:56 PM
>To: Guzman Lugo, Fernando; linux-omap@vger.kernel.org
>Cc: Doyu Hiroshi (Nokia-D/Helsinki); Palande Ameya (Nokia-D/Helsinki);
>Felipe Contreras
>Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630
>
>Fernando,
>
>> + if (cpu_is_omap2420() || cpu_is_omap3430() ||
>> + cpu_is_omap3630() || cpu_is_omap44xx())
>
>looks like this check is applied to all OMAPS. Can we just remove this
>check ?
There is more defines for more versions like:
cpu_is_omap2422
cpu_is_omap3503
... etc,
But I suppose that the mailbox is valid for all of them 24XX, 34XX, 36XX, 44XX. But then why it was only checking for cpu_is_omap2420 or cpu_is_omap3430 or cpu_is_omap44xx?
Maybe someone knows the reason. Otherwise I agree with you.
Regards,
Fernando.
>
>Thank you,
>Best regards,
>Hari
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH] OMAP3: add mailbox initialization for 3630
2010-03-25 23:44 ` Guzman Lugo, Fernando
@ 2010-03-26 5:25 ` Hiroshi DOYU
2010-03-26 17:05 ` Guzman Lugo, Fernando
0 siblings, 1 reply; 6+ messages in thread
From: Hiroshi DOYU @ 2010-03-26 5:25 UTC (permalink / raw)
To: x0095840; +Cc: h-kanigeri2, linux-omap, ameya.palande, felipe.contreras
From: "ext Guzman Lugo, Fernando" <x0095840@ti.com>
Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630
Date: Fri, 26 Mar 2010 00:44:38 +0100
>
>
>>-----Original Message-----
>>From: Kanigeri, Hari
>>Sent: Thursday, March 25, 2010 4:56 PM
>>To: Guzman Lugo, Fernando; linux-omap@vger.kernel.org
>>Cc: Doyu Hiroshi (Nokia-D/Helsinki); Palande Ameya (Nokia-D/Helsinki);
>>Felipe Contreras
>>Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630
>>
>>Fernando,
>>
>>> + if (cpu_is_omap2420() || cpu_is_omap3430() ||
>>> + cpu_is_omap3630() || cpu_is_omap44xx())
>>
>>looks like this check is applied to all OMAPS. Can we just remove this
>>check ?
>
> There is more defines for more versions like:
>
> cpu_is_omap2422
> cpu_is_omap3503
> ... etc,
>
> But I suppose that the mailbox is valid for all of them 24XX, 34XX, 36XX, 44XX. But then why it was only checking for cpu_is_omap2420 or cpu_is_omap3430 or cpu_is_omap44xx?
>
> Maybe someone knows the reason. Otherwise I agree with you.
When mailbox driver is introduced for the first time, "dspgateway"
only supported omap2420 since that's the one to have C55x dsp. Now the
type of dsp doesn't matter for mailbox anymore. I think that removing
the this type check would make sense now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: PATCH] OMAP3: add mailbox initialization for 3630
2010-03-26 5:25 ` Hiroshi DOYU
@ 2010-03-26 17:05 ` Guzman Lugo, Fernando
0 siblings, 0 replies; 6+ messages in thread
From: Guzman Lugo, Fernando @ 2010-03-26 17:05 UTC (permalink / raw)
To: Hiroshi DOYU
Cc: Kanigeri, Hari, linux-omap@vger.kernel.org,
ameya.palande@nokia.com, felipe.contreras@nokia.com
>-----Original Message-----
>From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
>Sent: Thursday, March 25, 2010 11:26 PM
>To: Guzman Lugo, Fernando
>Cc: Kanigeri, Hari; linux-omap@vger.kernel.org; ameya.palande@nokia.com;
>felipe.contreras@nokia.com
>Subject: Re: PATCH] OMAP3: add mailbox initialization for 3630
>
>From: "ext Guzman Lugo, Fernando" <x0095840@ti.com>
>Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630
>Date: Fri, 26 Mar 2010 00:44:38 +0100
>
>>
>>
>>>-----Original Message-----
>>>From: Kanigeri, Hari
>>>Sent: Thursday, March 25, 2010 4:56 PM
>>>To: Guzman Lugo, Fernando; linux-omap@vger.kernel.org
>>>Cc: Doyu Hiroshi (Nokia-D/Helsinki); Palande Ameya (Nokia-D/Helsinki);
>>>Felipe Contreras
>>>Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630
>>>
>>>Fernando,
>>>
>>>> + if (cpu_is_omap2420() || cpu_is_omap3430() ||
>>>> + cpu_is_omap3630() || cpu_is_omap44xx())
>>>
>>>looks like this check is applied to all OMAPS. Can we just remove this
>>>check ?
>>
>> There is more defines for more versions like:
>>
>> cpu_is_omap2422
>> cpu_is_omap3503
>> ... etc,
>>
>> But I suppose that the mailbox is valid for all of them 24XX, 34XX, 36XX,
>44XX. But then why it was only checking for cpu_is_omap2420 or
>cpu_is_omap3430 or cpu_is_omap44xx?
>>
>> Maybe someone knows the reason. Otherwise I agree with you.
>
>When mailbox driver is introduced for the first time, "dspgateway"
>only supported omap2420 since that's the one to have C55x dsp. Now the
>type of dsp doesn't matter for mailbox anymore. I think that removing
>the this type check would make sense now.
Ok, I will send the patch again with the change.
Regards,
Fernando.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH] OMAP3: add mailbox initialization for 3630
2010-03-25 22:51 PATCH] OMAP3: add mailbox initialization for 3630 Guzman Lugo, Fernando
2010-03-25 22:55 ` Kanigeri, Hari
@ 2010-03-25 23:01 ` Deepak Chitriki
1 sibling, 0 replies; 6+ messages in thread
From: Deepak Chitriki @ 2010-03-25 23:01 UTC (permalink / raw)
To: Guzman Lugo, Fernando
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Palande Ameya (Nokia-D/Helsinki), Felipe Contreras
Acked-by: Deepak Chitriki <deepak.chitriki@ti.com>
Deepak
Guzman Lugo, Fernando wrote:
> From 1fcfb230789f904de80c46b69c50879ee3f32ed8 Mon Sep 17 00:00:00 2001
> From: Fernando Guzman Lugo <x0095840@ti.com>
> Date: Thu, 25 Mar 2010 16:55:46 -0600
> Subject: [PATCH] OMAP3: add mailbox initialization for 3630
>
> This patch adds mailbox initialization for 3630
>
> Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> ---
> arch/arm/mach-omap2/devices.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 18ad931..f9d177b 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -196,7 +196,8 @@ static struct platform_device mbox_device = {
>
> static inline void omap_init_mbox(void)
> {
> - if (cpu_is_omap2420() || cpu_is_omap3430() || cpu_is_omap44xx()) {
> + if (cpu_is_omap2420() || cpu_is_omap3430() ||
> + cpu_is_omap3630() || cpu_is_omap44xx()) {
> mbox_device.num_resources = ARRAY_SIZE(omap_mbox_resources);
> mbox_device.resource = omap_mbox_resources;
> } else {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-26 17:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 22:51 PATCH] OMAP3: add mailbox initialization for 3630 Guzman Lugo, Fernando
2010-03-25 22:55 ` Kanigeri, Hari
2010-03-25 23:44 ` Guzman Lugo, Fernando
2010-03-26 5:25 ` Hiroshi DOYU
2010-03-26 17:05 ` Guzman Lugo, Fernando
2010-03-25 23:01 ` Deepak Chitriki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox