public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Sripathy, Vishwanath" <vishwanath.bs@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Paul Walmsley <paul@pwsan.com>
Subject: Re: [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor
Date: Tue, 6 Apr 2010 11:14:20 -0500	[thread overview]
Message-ID: <4BBB5DDC.3050000@ti.com> (raw)
In-Reply-To: <1270576596-8761-1-git-send-email-vishwanath.bs@ti.com>

Sripathy, Vishwanath had written, on 04/06/2010 12:56 PM, the following:
> opp_find_freq_floor should return the lower "enabled* OPP from a starting freq
> from a start opp list. But current code returns next lower opp. This patch fixes
> this issue.
> 
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> ---
> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
> index bb8120e..13da451
> --- a/arch/arm/plat-omap/opp.c
> +++ b/arch/arm/plat-omap/opp.c
> @@ -208,7 +208,7 @@ struct omap_opp *opp_find_freq_floor(enum opp_t opp_type, unsigned long *freq)
>  
>  	*freq = prev_opp->rate;
>  
> -	return oppl;
> +	return prev_opp;
>  }
>  
Thanks. yep. since we return *freq with the right rate, we should point 
also to the right opp.

Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2010-04-06 16:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 17:56 [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor Vishwanath BS
2010-04-06 16:14 ` Nishanth Menon [this message]
2010-04-06 18:39   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBB5DDC.3050000@ti.com \
    --to=nm@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox