* Re: [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor
2010-04-06 17:56 [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor Vishwanath BS
@ 2010-04-06 16:14 ` Nishanth Menon
2010-04-06 18:39 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2010-04-06 16:14 UTC (permalink / raw)
To: Sripathy, Vishwanath; +Cc: linux-omap@vger.kernel.org, Paul Walmsley
Sripathy, Vishwanath had written, on 04/06/2010 12:56 PM, the following:
> opp_find_freq_floor should return the lower "enabled* OPP from a starting freq
> from a start opp list. But current code returns next lower opp. This patch fixes
> this issue.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> ---
> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
> index bb8120e..13da451
> --- a/arch/arm/plat-omap/opp.c
> +++ b/arch/arm/plat-omap/opp.c
> @@ -208,7 +208,7 @@ struct omap_opp *opp_find_freq_floor(enum opp_t opp_type, unsigned long *freq)
>
> *freq = prev_opp->rate;
>
> - return oppl;
> + return prev_opp;
> }
>
Thanks. yep. since we return *freq with the right rate, we should point
also to the right opp.
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor
@ 2010-04-06 17:56 Vishwanath BS
2010-04-06 16:14 ` Nishanth Menon
0 siblings, 1 reply; 3+ messages in thread
From: Vishwanath BS @ 2010-04-06 17:56 UTC (permalink / raw)
To: linux-omap; +Cc: Vishwanath BS
opp_find_freq_floor should return the lower "enabled* OPP from a starting freq
from a start opp list. But current code returns next lower opp. This patch fixes
this issue.
Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
---
diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
index bb8120e..13da451
--- a/arch/arm/plat-omap/opp.c
+++ b/arch/arm/plat-omap/opp.c
@@ -208,7 +208,7 @@ struct omap_opp *opp_find_freq_floor(enum opp_t opp_type, unsigned long *freq)
*freq = prev_opp->rate;
- return oppl;
+ return prev_opp;
}
/* wrapper to reuse converting opp_def to opp struct */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor
2010-04-06 16:14 ` Nishanth Menon
@ 2010-04-06 18:39 ` Kevin Hilman
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2010-04-06 18:39 UTC (permalink / raw)
To: Nishanth Menon
Cc: Sripathy, Vishwanath, linux-omap@vger.kernel.org, Paul Walmsley
Nishanth Menon <nm@ti.com> writes:
> Sripathy, Vishwanath had written, on 04/06/2010 12:56 PM, the following:
>> opp_find_freq_floor should return the lower "enabled* OPP from a starting freq
>> from a start opp list. But current code returns next lower opp. This patch fixes
>> this issue.
>>
>> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
>> ---
>> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
>> index bb8120e..13da451
>> --- a/arch/arm/plat-omap/opp.c
>> +++ b/arch/arm/plat-omap/opp.c
>> @@ -208,7 +208,7 @@ struct omap_opp *opp_find_freq_floor(enum opp_t opp_type, unsigned long *freq)
>> *freq = prev_opp->rate;
>> - return oppl;
>> + return prev_opp;
>> }
>>
> Thanks. yep. since we return *freq with the right rate, we should
> point also to the right opp.
>
> Acked-by: Nishanth Menon <nm@ti.com>
Thanks, pushed to pm-wip-opp
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-06 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-06 17:56 [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor Vishwanath BS
2010-04-06 16:14 ` Nishanth Menon
2010-04-06 18:39 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox