From: "stanley.miao" <stanley.miao@windriver.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH 03/11] AM3517: rename the i2c boardinfo to make it more readable
Date: Wed, 14 Apr 2010 10:44:52 +0800 [thread overview]
Message-ID: <4BC52C24.8080707@windriver.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044E054200@dbde02.ent.ti.com>
Hiremath, Vaibhav wrote:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Stanley.Miao
>> Sent: Tuesday, April 13, 2010 3:02 PM
>> To: linux-omap@vger.kernel.org
>> Cc: tony@atomide.com
>> Subject: [PATCH 03/11] AM3517: rename the i2c boardinfo to make it more
>> readable
>>
>> There are three i3c buses on am3517,
>>
> [Hiremath, Vaibhav] Please correct the typo here.
>
I will correct it in V2.
Thanks.
>
>> now rename these three boardinfo
>> structure name to am3517evm_i2c1_boardinfo, am3517evm_i2c2_boardinfo,
>> and am3517evm_i2c3_boardinfo, to make it more readable.
>>
>> <snip>
>> }
>> @@ -425,8 +425,8 @@ static void __init am3517_evm_init(void)
>> /* RTC - S35390A */
>> am3517_evm_rtc_init();
>>
>> - i2c_register_board_info(1, am3517evm_i2c_boardinfo,
>> - ARRAY_SIZE(am3517evm_i2c_boardinfo));
>> + i2c_register_board_info(1, am3517evm_i2c1_boardinfo,
>> + ARRAY_SIZE(am3517evm_i2c1_boardinfo));
>> }
>>
> [Hiremath, Vaibhav] personally I like the idea of specifying explicitly the I2C instance here which you did, I have seen other board files using slave device name while defining the I2C board info. I am not sure about whether we have any standard thing to follow here.
>
> Let's take opinion from other folks here; if they are ok with this approach then I think we can merge this patch.
>
There are many slave devices on each i2c bus.
I2C1: S35390, TPS65023, TSC2004, four INA219.
I2C2: TCA6416PW, two TLV320AIC23
I2C3: two TCA6416PW, TLV320AIC23, TVP5146.
So we can't name the i2c board files with the slave device names
Stanley.
> Thanks,
> Vaibhav
>
>
>> static void __init am3517_evm_map_io(void)
>> --
>> 1.5.4.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
next prev parent reply other threads:[~2010-04-14 2:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 9:31 [PATCH 0/11] Some am3517 related patches Stanley.Miao
2010-04-13 9:31 ` [PATCH 01/11] omap: remove one of the define of INT_34XX_BENCH_MPU_EMUL Stanley.Miao
2010-04-13 9:31 ` [PATCH 02/11] AM3517: Add platform init code for EMAC driver Stanley.Miao
2010-04-13 9:31 ` [PATCH 03/11] AM3517: rename the i2c boardinfo to make it more readable Stanley.Miao
2010-04-13 16:29 ` Hiremath, Vaibhav
2010-04-14 2:44 ` stanley.miao [this message]
2010-04-13 9:31 ` [PATCH 04/11] AM3517: Add platform init code for regulator driver Stanley.Miao
2010-04-13 9:31 ` [PATCH 05/11] AM3517: Add audio codec platform data Stanley.Miao
2010-04-13 9:31 ` [PATCH 06/11] AM3517: Add nand platform data for am3517evm Stanley.Miao
2010-04-13 9:31 ` [PATCH 07/11] AM3517: initialize i2c subsystem after mux subsystem Stanley.Miao
2010-04-13 9:31 ` [PATCH 08/11] OMAP: fix a gpmc nand problem Stanley.Miao
2010-04-13 9:34 ` [PATCH 09/11] omap: init the gpio pinmux for mmc Stanley.Miao
2010-04-13 9:34 ` [PATCH 10/11] omap hsmmc: fix the hsmmc driver for am3517 Stanley.Miao
2010-04-13 13:03 ` Adrian Hunter
2010-04-13 13:06 ` Adrian Hunter
2010-04-14 3:34 ` stanley.miao
2010-04-13 9:34 ` [PATCH 11/11] AM3517: Add mmc platform data for am3517evm Stanley.Miao
2010-04-13 13:08 ` Adrian Hunter
2010-04-14 7:14 ` stanley.miao
2010-04-13 16:18 ` Hiremath, Vaibhav
2010-04-14 2:36 ` stanley.miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC52C24.8080707@windriver.com \
--to=stanley.miao@windriver.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox