[RFC][PATCH v1 9/19] DSPBRIDGE: Cleanup custom error code (DSP_EFOPEN ->- EBADF)

[RFC][PATCH v1 9/19] DSPBRIDGE: Cleanup custom error code (DSP_EFOPEN ->- EBADF)

[Hebbar, Shivananda]

>From 3bf9c85d6d0794e790491334dca1dde8d0ada863 Mon Sep 17 00:00:00 2001
From: Shivananda Hebbar <x0hebbar@ti.com>
Date: Tue, 23 Mar 2010 13:24:31 -0600
Subject: [PATCH] DSPBRIDGE: Cleanup custom error code (DSP_EFOPEN ->- EBADF)

This patch replaces DSP_EFOPEN with -EBADF

Signed-off-by: Shivananda Hebbar <x0hebbar@ti.com>
---
 arch/arm/plat-omap/include/dspbridge/dblldefs.h |    2 +-
 arch/arm/plat-omap/include/dspbridge/errbase.h  |    3 ---
 drivers/dsp/bridge/pmgr/dbll.c                  |    4 ++--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/plat-omap/include/dspbridge/dblldefs.h b/arch/arm/plat-omap/include/dspbridge/dblldefs.h
index fce35ab..527d47e 100644
--- a/arch/arm/plat-omap/include/dspbridge/dblldefs.h
+++ b/arch/arm/plat-omap/include/dspbridge/dblldefs.h
@@ -385,7 +385,7 @@ typedef dsp_status(*dbll_load_sect_fxn) (struct dbll_library_obj *lib,
  *  Returns:
  *      DSP_SOK:            Success.
  *      -ENOMEM:        Memory allocation failure.
- *      DSP_EFOPEN:         File open failure.
+ *      -EBADF:         File open failure.
  *      DSP_EFREAD:         File read failure.
  *      DSP_ECORRUPTFILE:   Unable to determine target type.
  *  Requires:
diff --git a/arch/arm/plat-omap/include/dspbridge/errbase.h b/arch/arm/plat-omap/include/dspbridge/errbase.h
index 09ae0c6..aa848c8 100644
--- a/arch/arm/plat-omap/include/dspbridge/errbase.h
+++ b/arch/arm/plat-omap/include/dspbridge/errbase.h
@@ -192,9 +192,6 @@
 /* Unable to find a named section in DSP executable */
 #define DSP_ENOSECT                 (DSP_EBASE + 0x32)
 
-/* Unable to open file */
-#define DSP_EFOPEN                  (DSP_EBASE + 0x33)
-
 /* Unable to read file */
 #define DSP_EFREAD                  (DSP_EBASE + 0x34)
 
diff --git a/drivers/dsp/bridge/pmgr/dbll.c b/drivers/dsp/bridge/pmgr/dbll.c
index 8d6f9ea..5544029 100644
--- a/drivers/dsp/bridge/pmgr/dbll.c
+++ b/drivers/dsp/bridge/pmgr/dbll.c
@@ -915,10 +915,10 @@ static dsp_status dof_open(struct dbll_library_obj *zl_lib)
 		if (zl_lib->desc == NULL) {
 			(zl_lib->target_obj->attrs.fclose) (zl_lib->fp);
 			zl_lib->fp = NULL;
-			status = DSP_EFOPEN;
+			status = -EBADF;
 		}
 	} else {
-		status = DSP_EFOPEN;
+		status = -EBADF;
 	}
 
 	return status;
-- 
1.6.0.4

Re: [RFC][PATCH v1 9/19] DSPBRIDGE: Cleanup custom error code (DSP_EFOPEN ->- EBADF)

[Omar Ramirez Luna]

On 3/26/2010 9:28 PM, Hebbar, Shivananda wrote:
>  From 3bf9c85d6d0794e790491334dca1dde8d0ada863 Mon Sep 17 00:00:00 2001
> From: Shivananda Hebbar<x0hebbar@ti.com>
> Date: Tue, 23 Mar 2010 13:24:31 -0600
> Subject: [PATCH] DSPBRIDGE: Cleanup custom error code (DSP_EFOPEN ->- EBADF)
>
> This patch replaces DSP_EFOPEN with -EBADF
>
> Signed-off-by: Shivananda Hebbar<x0hebbar@ti.com>

Rebased and pushed the entire series (1st set of 19 + 2nd set of 13), 
fixed some wrong patch subjects among other issues.

It seems there is one thing left though, let me know if you will take 
care of it.

TODO: print the status codes as decimal instead of hex.

- omar