* [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
@ 2010-05-19 1:22 Guzman Lugo, Fernando
2010-05-20 14:41 ` Deepak Chitriki
0 siblings, 1 reply; 3+ messages in thread
From: Guzman Lugo, Fernando @ 2010-05-19 1:22 UTC (permalink / raw)
To: linux-omap@vger.kernel.org
Cc: Hiroshi DOYU, Ameya Palande, Ramirez Luna, Omar, Felipe Contreras
>From 595a54c6a886d8e707e04cbf5d0d9b6d6de7c6ec Mon Sep 17 00:00:00 2001
From: Fernando Guzman Lugo <x0095840@ti.com>
Date: Tue, 18 May 2010 20:14:20 -0500
Subject: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
IVA mmu reset was not being done properly, so dsp bootaddress
was not copied to SYSC register. Given as a result DSP was not
booting from that address after reloading baseimage.
Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
drivers/dsp/bridge/core/tiomap3430.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dsp/bridge/core/tiomap3430.c b/drivers/dsp/bridge/core/tiomap3430.c
index c7b0d83..805e6f3 100644
--- a/drivers/dsp/bridge/core/tiomap3430.c
+++ b/drivers/dsp/bridge/core/tiomap3430.c
@@ -443,7 +443,7 @@ static dsp_status bridge_brd_start(struct bridge_dev_context *hDevContext,
/* Reset and Unreset the RST2, so that BOOTADDR is copied to
* IVA2 SYSC register */
(*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2,
- OMAP3430_RST1_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
+ OMAP3430_RST2_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
udelay(100);
(*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2, 0,
OMAP3430_IVA2_MOD, RM_RSTCTRL);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
2010-05-19 1:22 [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function Guzman Lugo, Fernando
@ 2010-05-20 14:41 ` Deepak Chitriki
2010-06-11 5:22 ` Ramirez Luna, Omar
0 siblings, 1 reply; 3+ messages in thread
From: Deepak Chitriki @ 2010-05-20 14:41 UTC (permalink / raw)
To: Guzman Lugo, Fernando
Cc: linux-omap@vger.kernel.org, Hiroshi DOYU, Ameya Palande,
Ramirez Luna, Omar, Felipe Contreras
Guzman Lugo, Fernando wrote:
> From 595a54c6a886d8e707e04cbf5d0d9b6d6de7c6ec Mon Sep 17 00:00:00 2001
> From: Fernando Guzman Lugo <x0095840@ti.com>
> Date: Tue, 18 May 2010 20:14:20 -0500
> Subject: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
>
> IVA mmu reset was not being done properly, so dsp bootaddress
> was not copied to SYSC register. Given as a result DSP was not
> booting from that address after reloading baseimage.
>
> Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> ---
> drivers/dsp/bridge/core/tiomap3430.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dsp/bridge/core/tiomap3430.c b/drivers/dsp/bridge/core/tiomap3430.c
> index c7b0d83..805e6f3 100644
> --- a/drivers/dsp/bridge/core/tiomap3430.c
> +++ b/drivers/dsp/bridge/core/tiomap3430.c
> @@ -443,7 +443,7 @@ static dsp_status bridge_brd_start(struct bridge_dev_context *hDevContext,
> /* Reset and Unreset the RST2, so that BOOTADDR is copied to
> * IVA2 SYSC register */
> (*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2,
> - OMAP3430_RST1_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
> + OMAP3430_RST2_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
> udelay(100);
> (*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2, 0,
> OMAP3430_IVA2_MOD, RM_RSTCTRL);
>
Tested by: Deepak chitriki<deepak.chitriki@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
2010-05-20 14:41 ` Deepak Chitriki
@ 2010-06-11 5:22 ` Ramirez Luna, Omar
0 siblings, 0 replies; 3+ messages in thread
From: Ramirez Luna, Omar @ 2010-06-11 5:22 UTC (permalink / raw)
To: Chitriki Rudramuni, Deepak, Guzman Lugo, Fernando
Cc: linux-omap@vger.kernel.org, Hiroshi DOYU, Ameya Palande,
Felipe Contreras
>From: Chitriki Rudramuni, Deepak
>Sent: Thursday, May 20, 2010 9:42 AM
>To: Guzman Lugo, Fernando
>Cc: linux-omap@vger.kernel.org; Hiroshi DOYU; Ameya Palande; Ramirez Luna, Omar; Felipe Contreras
>Subject: Re: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
>
>Guzman Lugo, Fernando wrote:
>> From 595a54c6a886d8e707e04cbf5d0d9b6d6de7c6ec Mon Sep 17 00:00:00 2001
>> From: Fernando Guzman Lugo <x0095840@ti.com>
>> Date: Tue, 18 May 2010 20:14:20 -0500
>> Subject: [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function
>>
>> IVA mmu reset was not being done properly, so dsp bootaddress
>> was not copied to SYSC register. Given as a result DSP was not
>> booting from that address after reloading baseimage.
>>
>> Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
>> ---
>> drivers/dsp/bridge/core/tiomap3430.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dsp/bridge/core/tiomap3430.c b/drivers/dsp/bridge/core/tiomap3430.c
>> index c7b0d83..805e6f3 100644
>> --- a/drivers/dsp/bridge/core/tiomap3430.c
>> +++ b/drivers/dsp/bridge/core/tiomap3430.c
>> @@ -443,7 +443,7 @@ static dsp_status bridge_brd_start(struct bridge_dev_context *hDevContext,
>> /* Reset and Unreset the RST2, so that BOOTADDR is copied to
>> * IVA2 SYSC register */
>> (*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2,
>> - OMAP3430_RST1_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
>> + OMAP3430_RST2_IVA2, OMAP3430_IVA2_MOD, RM_RSTCTRL);
>> udelay(100);
>> (*pdata->dsp_prm_rmw_bits)(OMAP3430_RST2_IVA2, 0,
>> OMAP3430_IVA2_MOD, RM_RSTCTRL);
>>
>Tested by: Deepak chitriki<deepak.chitriki@ti.com>
Pushed to dspbridge.
- Omar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-11 5:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19 1:22 [PATCH] DSPBRIDGE: fix incorrect reset in bridge_brd_start function Guzman Lugo, Fernando
2010-05-20 14:41 ` Deepak Chitriki
2010-06-11 5:22 ` Ramirez Luna, Omar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).