From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghu Subject: Re: DSS2 failure with current linux-omap head Date: Mon, 24 May 2010 16:38:17 -0500 Message-ID: <4BFAF1C9.10906@gmail.com> References: <1274429232.4246.65.camel@tubuntu.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:39539 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754993Ab0EXVjw (ORCPT ); Mon, 24 May 2010 17:39:52 -0400 Received: by iwn6 with SMTP id 6so4036477iwn.19 for ; Mon, 24 May 2010 14:39:51 -0700 (PDT) In-Reply-To: <1274429232.4246.65.camel@tubuntu.research.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tomi Valkeinen Cc: ext Steve Sakoman , "linux-omap@vger.kernel.org" On 05/21/2010 03:07 AM, Tomi Valkeinen wrote: > On Thu, 2010-05-20 at 00:33 +0200, ext Steve Sakoman wrote: >> I did a quick test build of the current linux-omap head and get a >> failure very early on in the boot process in >> drivers/video/omap2/vram.c code: >> >> Illegal SDRAM size for VRAM >> >> It is generated by the following code: >> >> bdata = NODE_DATA(0)->bdata; >> sdram_start = bdata->node_min_pfn<< PAGE_SHIFT; >> sdram_size = (bdata->node_low_pfn<< PAGE_SHIFT) - sdram_start; >> >> if (paddr) { >> if ((paddr& ~PAGE_MASK) || paddr< sdram_start || >> paddr + size> sdram_start + sdram_size) { >> pr_err("Illegal SDRAM region for VRAM\n"); >> return; >> } >> >> if (reserve_bootmem(paddr, size, BOOTMEM_EXCLUSIVE)< 0) { >> pr_err("FB: failed to reserve VRAM\n"); >> return; >> } >> } else { >> if (size> sdram_size) { >> pr_err("Illegal SDRAM size for VRAM\n"); >> return; >> } >> >> paddr = virt_to_phys(alloc_bootmem_pages(size)); >> BUG_ON(paddr& ~PAGE_MASK); >> } >> >> >> I modified the error pr_error to display the two values that are >> compared to generate this error: >> >> Illegal SDRAM size for VRAM: size=0xc00000 sdram_size=0x0 >> >> So it appears that the method used to get the sdram size no longer >> works since it returns a size of 0! > > I copied the method from the older omapfb driver, and I have to say that > I've never looked at what it actually does. Perhaps there's a proper way > to get the RAM starts and sizes somewhere... > > Tomi > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html when i enable bootmem debug, I can see its trying to reserve VRAM memory way before bootmem setup. VRAM: vram size = 12582912 VRAM: min page frame #: 0 VRAM: low page frame #: 0 VRAM: SDRM start: 0 VRAM: SDRAM size = 0 Illegal SDRAM size for VRAM bootmem::init_bootmem_core nid=0 start=80000 map=87fff end=88000 mapsize=1000 bootmem::mark_bootmem_node nid=0 start=80000 end=88000 reserve=0 flags=0 bootmem::__free nid=0 start=80000 end=88000 bootmem::mark_bootmem_node nid=0 start=80004 end=80432 reserve=1 flags=0 bootmem::__reserve nid=0 start=80004 end=80432 flags=0 bootmem::mark_bootmem_node nid=0 start=81ffd end=82000 reserve=1 flags=0 bootmem::__reserve nid=0 start=81ffd end=82000 flags=0 bootmem::mark_bootmem_node nid=0 start=87fff end=88000 reserve=1 flags=0 bootmem::__reserve nid=0 start=87fff end=88000 flags=0 On node 0 totalpages: 32768 bootmem::alloc_bootmem_core nid=0 size=100000 [256 pages] align=40 goal=bfffffff limit=0 bootmem::__reserve nid=0 start=80432 end=80532 flags=1 free_area_init_node: node 0, pgdat c0415d3c, node_mem_map c0432000 Normal zone: 256 pages used for memmap Normal zone: 0 pages reserved Normal zone: 32512 pages, LIFO batch:7 bootmem::alloc_bootmem_core nid=0 size=c [1 pages] align=40 goal=bfffffff limit= 0 bootmem::__reserve nid=0 start=80532 end=80533 flags=1 bootmem::alloc_bootmem_core nid=0 size=400 [1 pages] align=40 goal=bfffffff limi t=0 bootmem::__reserve nid=0 start=80533 end=80533 flags=1 bootmem::alloc_bootmem_core nid=0 size=1c [1 pages] align=40 goal=0 limit=ffffff ff bootmem::__reserve nid=0 start=80533 end=80533 flags=1 bootmem::alloc_bootmem_core nid=0 size=d5 [1 pages] align=40 goal=0 limit=0 bootmem::__reserve nid=0 start=80533 end=80533 flags=1 bootmem::alloc_bootmem_core nid=0 size=d5 [1 pages] align=40 goal=0 limit=0 bootmem::__reserve nid=0 start=80533 end=80533 flags=1 Built 1 zonelists in Zone order, mobility grouping on. Total pages: 32512 bootmem::alloc_bootmem_core nid=0 size=800 [1 pages] align=40 goal=0 limit=0 bootmem::__reserve nid=0 start=80533 end=80533 flags=1 PID hash table entries: 512 (order: -1, 2048 bytes) bootmem::alloc_bootmem_core nid=0 size=10000 [16 pages] align=40 goal=0 limit=0 bootmem::__reserve nid=0 start=80533 end=80543 flags=1 Dentry cache hash table entries: 16384 (order: 4, 65536 bytes) bootmem::alloc_bootmem_core nid=0 size=8000 [8 pages] align=40 goal=0 limit=0 bootmem::__reserve nid=0 start=80543 end=8054b flags=1 Inode-cache hash table entries: 8192 (order: 3, 32768 bytes) bootmem::free_all_bootmem_core nid=0 start=80000 end=88000 aligned=1 bootmem::free_all_bootmem_core nid=0 released=7ab6 Memory: 128MB = 128MB total -- Best Regards, Ragha