Re: [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS

[Benoit Cousson <b-cousson@ti.com>]

On 5/29/2010 4:37 PM, Gopinath, Thara wrote:
> This patch series converts the OMAP Dual Mode Timer into a
> platform driver. This involves using of hwmod structures and
> omap_device layer for OMAP2/3/4 dmtimers and generic
> linux platform device layer for OMAP1.
>
> As a result of this patch series the dmtimer platform driver
> resides in arch/arm/plat-omap directory and arch specific
> implementations and device registerations reside in
> arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1
> and OMAP2 PLUS respectively.

Hi Thara,

The Dual timer terminology is not used anymore since 2420.
It was replaced by gptimer and will be simplified going forward
using timer. This IP is almost the same since 1610, but will have 3 
different names.
It might be the good opportunity to align the names?
(OK, the code is full of dm_timer everywhere... so that might not worth 
the effort).
Let's consider that as my 2 cents...

Benoit


> This patch series has been compile tested for OMAP1 using
> omap_1610_h2_defconfig, compile tested for OMAP2 using
> omap3_defconfig and boot and sanity tested for OMAP3/OMAP4
> again using omap3_defconfig. Boot testing has been done
> on OMAP3430 SDP and OMAP4430 SDP boards. All testing has
> been done on origin/origin/pm-wip/hwmods-omap4 branch off
> Kevin Hilman's tree as these patches have dependencies on
> runtime pm API's and OMAP4 autogenerated hwmod data base.
>
> It would be great if somebody could test these patches on OMAP1
> and OMAP2 platforms.
>
> Thara Gopinath (9):
>    OMAP: Convert dual mode timer into a platform driver.
>    OMAP1: Dual mode timer device registration.
>    OMAP2/3/4 : Dual mode timer device registration.
>    OMAP2: Support for early device registration
>    OMAP2/3/4: Adding device names to dmtimer fclk nodes
>    OMAP3: Add hwmod data for OMAP3 dual mode timers.
>    OMAP2: Add hwmod data for OMAP2420 dual mode timers.
>    OMAP2: Add hwmod data for OMAP2430 dual mode timers.
>    OMAP4: Changing dmtimer1 fclk name
>
>   arch/arm/mach-omap1/Makefile               |    1 +
>   arch/arm/mach-omap1/dmtimers.c             |  148 +++++++
>   arch/arm/mach-omap1/timer32k.c             |    3 -
>   arch/arm/mach-omap2/Makefile               |    3 +-
>   arch/arm/mach-omap2/clock2420_data.c       |   24 +-
>   arch/arm/mach-omap2/clock2430_data.c       |   24 +-
>   arch/arm/mach-omap2/clock3xxx_data.c       |   22 +-
>   arch/arm/mach-omap2/clock44xx_data.c       |   24 +-
>   arch/arm/mach-omap2/dmtimers.c             |  296 +++++++++++++
>   arch/arm/mach-omap2/dmtimers.h             |   57 +++
>   arch/arm/mach-omap2/io.c                   |   16 +
>   arch/arm/mach-omap2/omap_hwmod_2420_data.c |  619 +++++++++++++++++++++++++++-
>   arch/arm/mach-omap2/omap_hwmod_2430_data.c |  619 +++++++++++++++++++++++++++-
>   arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  572 +++++++++++++++++++++++++-
>   arch/arm/mach-omap2/timer-gp.c             |    2 -
>   arch/arm/plat-omap/dmtimer.c               |  401 ++++++++-----------
>   arch/arm/plat-omap/include/plat/dmtimer.h  |   12 +-
>   17 files changed, 2550 insertions(+), 293 deletions(-)
>   create mode 100644 arch/arm/mach-omap1/dmtimers.c
>   create mode 100644 arch/arm/mach-omap2/dmtimers.c
>   create mode 100644 arch/arm/mach-omap2/dmtimers.h
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html