From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH 11/13 v3] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init Date: Tue, 15 Jun 2010 19:22:53 +0200 Message-ID: <4C17B6ED.203@ti.com> References: <1276614348-5201-1-git-send-email-charu@ti.com> <1276614348-5201-2-git-send-email-charu@ti.com> <1276614348-5201-3-git-send-email-charu@ti.com> <1276614348-5201-4-git-send-email-charu@ti.com> <1276614348-5201-5-git-send-email-charu@ti.com> <1276614348-5201-6-git-send-email-charu@ti.com> <1276614348-5201-7-git-send-email-charu@ti.com> <1276614348-5201-8-git-send-email-charu@ti.com> <1276614348-5201-9-git-send-email-charu@ti.com> <1276614348-5201-10-git-send-email-charu@ti.com> <1276614348-5201-11-git-send-email-charu@ti.com> <1276614348-5201-12-git-send-email-charu@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:60759 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758047Ab0FORXf (ORCPT ); Tue, 15 Jun 2010 13:23:35 -0400 In-Reply-To: <1276614348-5201-12-git-send-email-charu@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Varadarajan, Charulatha" Cc: "david-b@pacbell.net" , "broonie@opensource.wolfsonmicro.com" , "akpm@linux-foundation.org" , "linux-omap@vger.kernel.org" , "paul@pwsan.com" , "Nayak, Rajendra" , "khilman@deeprootsystems.com" , "tony@atomide.com" On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: > From: Charulatha V > > This patch adds support for handling GPIO as a HWMOD FW adapted > platform device for OMAP2PLUS chips. > > gpio_init needs to be done before machine_init functions access gpio APIs. > Hence gpio_init is made as a postcore_initcall. > > Signed-off-by: Charulatha V > --- > arch/arm/mach-omap2/gpio.c | 104 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 104 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-omap2/gpio.c > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > new file mode 100644 > index 0000000..993995a > --- /dev/null > +++ b/arch/arm/mach-omap2/gpio.c > @@ -0,0 +1,104 @@ > +/* > + * gpio.c - OMAP2PLUS-specific gpio code > + * > + * Copyright (C) 2010 Texas Instruments, Inc. > + * > + * Author: > + * Charulatha V > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include > +#include > +#include > + > +#include > +#include > + > +static struct omap_device_pm_latency omap_gpio_latency[] = { > + [0] = { > + .deactivate_func = omap_device_idle_hwmods, > + .activate_func = omap_device_enable_hwmods, > + .flags = OMAP_DEVICE_LATENCY_AUTO_ADJUST, > + }, > +}; > + > +static int omap2_init_gpio(struct omap_hwmod *oh, void *user) > +{ > + struct omap_device *od; > + struct omap_gpio_platform_data *pdata; > + char *name = "omap-gpio"; > + static int id; > + struct omap_gpio_dev_attr *gpio_dev_data; > + > + if (!oh) > + pr_err("Could not look up omap gpio %d\n", id + 1); > + > + pdata = kzalloc(sizeof(struct omap_gpio_platform_data), > + GFP_KERNEL); > + if (!pdata) { > + pr_err("Memory allocation failed gpio%d\n", id + 1); > + return -ENOMEM; > + } > + > + gpio_dev_data = (struct omap_gpio_dev_attr *)oh->dev_attr; > + pdata->gpio_attr = gpio_dev_data; > + pdata->method = (int)user; That method seems to be an IP version specific information and not a Soc specific one. You should store that in the hwmod dev_attr. What does 'method' mean in that context? Maybe the name should be revisited? > + pdata->virtual_irq_start = IH_GPIO_BASE + 32 * id; > + > + od = omap_device_build(name, id, oh, pdata, > + sizeof(*pdata), omap_gpio_latency, > + ARRAY_SIZE(omap_gpio_latency), > + false); > + WARN(IS_ERR(od), "Cant build omap_device for %s:%s.\n", > + name, oh->name); > + > + id++; > + return 0; > +} > + > +static int __init gpio_init(int method) > +{ > + return omap_hwmod_for_each_by_class("gpio", omap2_init_gpio, > + (void *)method); > +} > + > +/* > + * gpio_init needs to be done before > + * machine_init functions access gpio APIs. > + * Hence gpio_init is a postcore_initcall. > + */ > +#ifdef CONFIG_ARCH_OMAP2 > +static int __init omap24xx_gpio_init(void) > +{ if (!cpu_is_omap24xx()) > + return -EINVAL; > + > + return gpio_init(METHOD_GPIO_24XX); > +} > +postcore_initcall(omap24xx_gpio_init); > +#endif > + > +#ifdef CONFIG_ARCH_OMAP3 > +static int __init omap3xxx_gpio_init(void) > +{ > + if (!cpu_is_omap34xx()) > + return -EINVAL; > + > + return gpio_init(METHOD_GPIO_24XX); > +} > +postcore_initcall(omap3xxx_gpio_init); > +#endif > + > +#ifdef CONFIG_ARCH_OMAP4 > +static int __init omap44xx_gpio_init(void) > +{ > + if (!cpu_is_omap44xx()) > + return -EINVAL; > + > + return gpio_init(METHOD_GPIO_44XX); > +} You can avoid all this duplication of code by using the dev_attr instead of using a parameter. Benoit