From: Igor Grinberg <grinberg@compulab.co.il>
To: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts
Date: Mon, 26 Jul 2010 11:34:00 +0300 [thread overview]
Message-ID: <4C4D4878.9050703@compulab.co.il> (raw)
In-Reply-To: <1280131405.2427.11.camel@tubuntu.research.nokia.com>
>
> On Wed, 2010-07-21 at 16:36 +0200, ext Igor Grinberg wrote:
>
>> ping!
>>
> Man has to have his vacation!
>
>
Well, sorry for that...
I had no idea you are on vacation, but I hope you had a good one :)
>>> TDO35S samples the data on the falling adge of the pixel clock,
>>> therefore the data strobe should be on the raising edge.
>>>
> Looks fine to me, except I'd like the patch subject to be in line with
> the other patches (ie. prefixed by OMAP: DSS2: ...), and I think it
> should describe the change more precisely, perhaps something like "fix
> the video signal".
>
>
I'm still new to omap and mostly worked on pxa's till now,
so I brought the subject from there...
> I can make those changes as I apply it to my tree, if it's ok to you.
>
It is completely fine with me :)
> Tomi
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Regards,
Igor.
prev parent reply other threads:[~2010-07-26 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 10:42 [PATCH] [ARM] video/omap2/tdo35s: fix visual artefacts Igor Grinberg
2010-07-18 10:11 ` Igor Grinberg
2010-07-21 14:36 ` Igor Grinberg
2010-07-26 8:03 ` Tomi Valkeinen
2010-07-26 8:34 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4D4878.9050703@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=tomi.valkeinen@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox