From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Varadarajan, Charulatha" <charu@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"Nayak, Rajendra" <rnayak@ti.com>,
"Basak, Partha" <p-basak2@ti.com>
Subject: Re: [PATCH] OMAP4: HWMOD: Do omap_hwmod_late_init for OMAP4
Date: Fri, 06 Aug 2010 14:35:34 +0200 [thread overview]
Message-ID: <4C5C0196.3040106@ti.com> (raw)
In-Reply-To: <1281097873-24094-1-git-send-email-charu@ti.com>
Hi Charu,
On 8/6/2010 2:31 PM, Varadarajan, Charulatha wrote:
> This patch includes "cpu_is" check for omap44xx cpu inorder to do
> omap_hwmod_late_init() without which hwmods initialization does not
> happen for omap4.
>
> Signed-off-by: Charulatha V<charu@ti.com>
> Signed-off-by: Basak, Partha<p-basak2@ti.com>
> ---
> arch/arm/mach-omap2/io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index b89e678..9b15f46 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -345,7 +345,7 @@ void __init omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
> #ifndef CONFIG_PM_RUNTIME
> skip_setup_idle = 1;
> #endif
> - if (cpu_is_omap24xx() || cpu_is_omap34xx()) /* FIXME: OMAP4 */
> + if (cpu_is_omap24xx() || cpu_is_omap34xx() || cpu_is_omap44xx())
> omap_hwmod_late_init(skip_setup_idle);
>
> if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
This is already done in this patch:
[PATCH v3 1/7] OMAP4: hwmod: Add initial data for OMAP4430 ES1 & ES2
https://patchwork.kernel.org/patch/117347/
Benoit
next prev parent reply other threads:[~2010-08-06 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 12:31 [PATCH] OMAP4: HWMOD: Do omap_hwmod_late_init for OMAP4 Charulatha V
2010-08-06 12:35 ` Shilimkar, Santosh
2010-08-06 12:35 ` Cousson, Benoit [this message]
2010-08-09 12:35 ` Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5C0196.3040106@ti.com \
--to=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox