* [PATCH V2] OMAP: DSS2: don't power off a panel twice
@ 2010-08-11 3:19 Stanley.Miao
2010-08-11 6:50 ` Bryan Wu
2010-08-17 10:34 ` Tomi Valkeinen
0 siblings, 2 replies; 8+ messages in thread
From: Stanley.Miao @ 2010-08-11 3:19 UTC (permalink / raw)
To: linux-omap; +Cc: lwalkera, lwalkera, tomi.valkeinen
If we blank the panel by
echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
Then, we reboot the sytem, the kernel will crash at
drivers/video/omap2/dss/core.c:323
This is because the panel is closed twice. Now check the state of a dssdev
to forbid a panel is power on or power off twice.
Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
---
drivers/video/omap2/displays/panel-acx565akm.c | 6 ++++++
drivers/video/omap2/displays/panel-generic.c | 6 ++++++
.../video/omap2/displays/panel-sharp-lq043t1dg01.c | 6 ++++++
.../video/omap2/displays/panel-sharp-ls037v7dw01.c | 6 ++++++
drivers/video/omap2/displays/panel-taal.c | 6 ++++++
.../video/omap2/displays/panel-toppoly-tdo35s.c | 6 ++++++
.../video/omap2/displays/panel-tpo-td043mtea1.c | 6 ++++++
7 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
index 1f8eb70..374cbeb 100644
--- a/drivers/video/omap2/displays/panel-acx565akm.c
+++ b/drivers/video/omap2/displays/panel-acx565akm.c
@@ -587,6 +587,9 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev)
dev_dbg(&dssdev->dev, "%s\n", __func__);
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
mutex_lock(&md->mutex);
r = omapdss_sdi_display_enable(dssdev);
@@ -642,6 +645,9 @@ static void acx_panel_power_off(struct omap_dss_device *dssdev)
dev_dbg(&dssdev->dev, "%s\n", __func__);
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
mutex_lock(&md->mutex);
if (!md->enabled) {
diff --git a/drivers/video/omap2/displays/panel-generic.c b/drivers/video/omap2/displays/panel-generic.c
index 300eff5..395a68d 100644
--- a/drivers/video/omap2/displays/panel-generic.c
+++ b/drivers/video/omap2/displays/panel-generic.c
@@ -39,6 +39,9 @@ static int generic_panel_power_on(struct omap_dss_device *dssdev)
{
int r;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
r = omapdss_dpi_display_enable(dssdev);
if (r)
goto err0;
@@ -58,6 +61,9 @@ err0:
static void generic_panel_power_off(struct omap_dss_device *dssdev)
{
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
if (dssdev->platform_disable)
dssdev->platform_disable(dssdev);
diff --git a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
index 1026746..0c6896c 100644
--- a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
+++ b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
@@ -43,6 +43,9 @@ static int sharp_lq_panel_power_on(struct omap_dss_device *dssdev)
{
int r;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
r = omapdss_dpi_display_enable(dssdev);
if (r)
goto err0;
@@ -65,6 +68,9 @@ err0:
static void sharp_lq_panel_power_off(struct omap_dss_device *dssdev)
{
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
if (dssdev->platform_disable)
dssdev->platform_disable(dssdev);
diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
index 7d9eb2b..9a138f6 100644
--- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
+++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
@@ -135,6 +135,9 @@ static int sharp_ls_power_on(struct omap_dss_device *dssdev)
{
int r = 0;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
r = omapdss_dpi_display_enable(dssdev);
if (r)
goto err0;
@@ -157,6 +160,9 @@ err0:
static void sharp_ls_power_off(struct omap_dss_device *dssdev)
{
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
if (dssdev->platform_disable)
dssdev->platform_disable(dssdev);
diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
index aaf5d30..c649f06 100644
--- a/drivers/video/omap2/displays/panel-taal.c
+++ b/drivers/video/omap2/displays/panel-taal.c
@@ -635,6 +635,9 @@ static int taal_power_on(struct omap_dss_device *dssdev)
u8 id1, id2, id3;
int r;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
if (dssdev->platform_enable) {
r = dssdev->platform_enable(dssdev);
if (r)
@@ -715,6 +718,9 @@ static void taal_power_off(struct omap_dss_device *dssdev)
{
struct taal_data *td = dev_get_drvdata(&dssdev->dev);
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
dsi_bus_lock();
cancel_delayed_work(&td->esd_work);
diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
index fa434ca..49e1dec 100644
--- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
+++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
@@ -46,6 +46,9 @@ static int toppoly_tdo_panel_power_on(struct omap_dss_device *dssdev)
{
int r;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
r = omapdss_dpi_display_enable(dssdev);
if (r)
goto err0;
@@ -65,6 +68,9 @@ err0:
static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
{
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
if (dssdev->platform_disable)
dssdev->platform_disable(dssdev);
diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
index e866e76..dbe9d43 100644
--- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
@@ -269,6 +269,9 @@ static int tpo_td043_power_on(struct omap_dss_device *dssdev)
int nreset_gpio = dssdev->reset_gpio;
int r;
+ if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
+ return 0;
+
r = omapdss_dpi_display_enable(dssdev);
if (r)
goto err0;
@@ -308,6 +311,9 @@ static void tpo_td043_power_off(struct omap_dss_device *dssdev)
struct tpo_td043_device *tpo_td043 = dev_get_drvdata(&dssdev->dev);
int nreset_gpio = dssdev->reset_gpio;
+ if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
+ return;
+
tpo_td043_write(tpo_td043->spi, 3,
TPO_R03_VAL_STANDBY | TPO_R03_EN_PWM);
--
1.5.4.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-11 3:19 [PATCH V2] OMAP: DSS2: don't power off a panel twice Stanley.Miao
@ 2010-08-11 6:50 ` Bryan Wu
2010-08-17 9:01 ` Bryan Wu
2010-08-17 10:34 ` Tomi Valkeinen
1 sibling, 1 reply; 8+ messages in thread
From: Bryan Wu @ 2010-08-11 6:50 UTC (permalink / raw)
To: Stanley.Miao; +Cc: linux-omap, lwalkera, lwalkera, tomi.valkeinen
Tested on my Beagle board. It fixed the issue.
Thanks,
-Bryan
On 08/11/2010 11:19 AM, Stanley.Miao wrote:
> If we blank the panel by
> echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
>
> Then, we reboot the sytem, the kernel will crash at
> drivers/video/omap2/dss/core.c:323
>
> This is because the panel is closed twice. Now check the state of a dssdev
> to forbid a panel is power on or power off twice.
>
> Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
> ---
> drivers/video/omap2/displays/panel-acx565akm.c | 6 ++++++
> drivers/video/omap2/displays/panel-generic.c | 6 ++++++
> .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 6 ++++++
> .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 6 ++++++
> drivers/video/omap2/displays/panel-taal.c | 6 ++++++
> .../video/omap2/displays/panel-toppoly-tdo35s.c | 6 ++++++
> .../video/omap2/displays/panel-tpo-td043mtea1.c | 6 ++++++
> 7 files changed, 42 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
> index 1f8eb70..374cbeb 100644
> --- a/drivers/video/omap2/displays/panel-acx565akm.c
> +++ b/drivers/video/omap2/displays/panel-acx565akm.c
> @@ -587,6 +587,9 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev)
>
> dev_dbg(&dssdev->dev, "%s\n", __func__);
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> mutex_lock(&md->mutex);
>
> r = omapdss_sdi_display_enable(dssdev);
> @@ -642,6 +645,9 @@ static void acx_panel_power_off(struct omap_dss_device *dssdev)
>
> dev_dbg(&dssdev->dev, "%s\n", __func__);
>
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> mutex_lock(&md->mutex);
>
> if (!md->enabled) {
> diff --git a/drivers/video/omap2/displays/panel-generic.c b/drivers/video/omap2/displays/panel-generic.c
> index 300eff5..395a68d 100644
> --- a/drivers/video/omap2/displays/panel-generic.c
> +++ b/drivers/video/omap2/displays/panel-generic.c
> @@ -39,6 +39,9 @@ static int generic_panel_power_on(struct omap_dss_device *dssdev)
> {
> int r;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> r = omapdss_dpi_display_enable(dssdev);
> if (r)
> goto err0;
> @@ -58,6 +61,9 @@ err0:
>
> static void generic_panel_power_off(struct omap_dss_device *dssdev)
> {
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> if (dssdev->platform_disable)
> dssdev->platform_disable(dssdev);
>
> diff --git a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
> index 1026746..0c6896c 100644
> --- a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
> +++ b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
> @@ -43,6 +43,9 @@ static int sharp_lq_panel_power_on(struct omap_dss_device *dssdev)
> {
> int r;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> r = omapdss_dpi_display_enable(dssdev);
> if (r)
> goto err0;
> @@ -65,6 +68,9 @@ err0:
>
> static void sharp_lq_panel_power_off(struct omap_dss_device *dssdev)
> {
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> if (dssdev->platform_disable)
> dssdev->platform_disable(dssdev);
>
> diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
> index 7d9eb2b..9a138f6 100644
> --- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
> +++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
> @@ -135,6 +135,9 @@ static int sharp_ls_power_on(struct omap_dss_device *dssdev)
> {
> int r = 0;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> r = omapdss_dpi_display_enable(dssdev);
> if (r)
> goto err0;
> @@ -157,6 +160,9 @@ err0:
>
> static void sharp_ls_power_off(struct omap_dss_device *dssdev)
> {
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> if (dssdev->platform_disable)
> dssdev->platform_disable(dssdev);
>
> diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
> index aaf5d30..c649f06 100644
> --- a/drivers/video/omap2/displays/panel-taal.c
> +++ b/drivers/video/omap2/displays/panel-taal.c
> @@ -635,6 +635,9 @@ static int taal_power_on(struct omap_dss_device *dssdev)
> u8 id1, id2, id3;
> int r;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> if (dssdev->platform_enable) {
> r = dssdev->platform_enable(dssdev);
> if (r)
> @@ -715,6 +718,9 @@ static void taal_power_off(struct omap_dss_device *dssdev)
> {
> struct taal_data *td = dev_get_drvdata(&dssdev->dev);
>
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> dsi_bus_lock();
>
> cancel_delayed_work(&td->esd_work);
> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> index fa434ca..49e1dec 100644
> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
> @@ -46,6 +46,9 @@ static int toppoly_tdo_panel_power_on(struct omap_dss_device *dssdev)
> {
> int r;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> r = omapdss_dpi_display_enable(dssdev);
> if (r)
> goto err0;
> @@ -65,6 +68,9 @@ err0:
>
> static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
> {
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> if (dssdev->platform_disable)
> dssdev->platform_disable(dssdev);
>
> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> index e866e76..dbe9d43 100644
> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> @@ -269,6 +269,9 @@ static int tpo_td043_power_on(struct omap_dss_device *dssdev)
> int nreset_gpio = dssdev->reset_gpio;
> int r;
>
> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> + return 0;
> +
> r = omapdss_dpi_display_enable(dssdev);
> if (r)
> goto err0;
> @@ -308,6 +311,9 @@ static void tpo_td043_power_off(struct omap_dss_device *dssdev)
> struct tpo_td043_device *tpo_td043 = dev_get_drvdata(&dssdev->dev);
> int nreset_gpio = dssdev->reset_gpio;
>
> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
> + return;
> +
> tpo_td043_write(tpo_td043->spi, 3,
> TPO_R03_VAL_STANDBY | TPO_R03_EN_PWM);
>
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-11 6:50 ` Bryan Wu
@ 2010-08-17 9:01 ` Bryan Wu
2010-08-17 9:27 ` stanley.miao
0 siblings, 1 reply; 8+ messages in thread
From: Bryan Wu @ 2010-08-17 9:01 UTC (permalink / raw)
To: bryan.wu, Stanley.Miao, linux-omap; +Cc: lwalkera, lwalkera, tomi.valkeinen
Is there any feedback about this patch,
Tested-by: Bryan Wu <bryan.wu@canonical.com>
-Bryan
On 08/11/2010 02:50 PM, Bryan Wu wrote:
> Tested on my Beagle board. It fixed the issue.
>
> Thanks,
> -Bryan
>
> On 08/11/2010 11:19 AM, Stanley.Miao wrote:
>> If we blank the panel by
>> echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
>>
>> Then, we reboot the sytem, the kernel will crash at
>> drivers/video/omap2/dss/core.c:323
>>
>> This is because the panel is closed twice. Now check the state of a dssdev
>> to forbid a panel is power on or power off twice.
>>
>> Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
>> ---
>> drivers/video/omap2/displays/panel-acx565akm.c | 6 ++++++
>> drivers/video/omap2/displays/panel-generic.c | 6 ++++++
>> .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 6 ++++++
>> .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 6 ++++++
>> drivers/video/omap2/displays/panel-taal.c | 6 ++++++
>> .../video/omap2/displays/panel-toppoly-tdo35s.c | 6 ++++++
>> .../video/omap2/displays/panel-tpo-td043mtea1.c | 6 ++++++
>> 7 files changed, 42 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
>> index 1f8eb70..374cbeb 100644
>> --- a/drivers/video/omap2/displays/panel-acx565akm.c
>> +++ b/drivers/video/omap2/displays/panel-acx565akm.c
>> @@ -587,6 +587,9 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev)
>>
>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> mutex_lock(&md->mutex);
>>
>> r = omapdss_sdi_display_enable(dssdev);
>> @@ -642,6 +645,9 @@ static void acx_panel_power_off(struct omap_dss_device *dssdev)
>>
>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> mutex_lock(&md->mutex);
>>
>> if (!md->enabled) {
>> diff --git a/drivers/video/omap2/displays/panel-generic.c b/drivers/video/omap2/displays/panel-generic.c
>> index 300eff5..395a68d 100644
>> --- a/drivers/video/omap2/displays/panel-generic.c
>> +++ b/drivers/video/omap2/displays/panel-generic.c
>> @@ -39,6 +39,9 @@ static int generic_panel_power_on(struct omap_dss_device *dssdev)
>> {
>> int r;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> r = omapdss_dpi_display_enable(dssdev);
>> if (r)
>> goto err0;
>> @@ -58,6 +61,9 @@ err0:
>>
>> static void generic_panel_power_off(struct omap_dss_device *dssdev)
>> {
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> if (dssdev->platform_disable)
>> dssdev->platform_disable(dssdev);
>>
>> diff --git a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>> index 1026746..0c6896c 100644
>> --- a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>> +++ b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>> @@ -43,6 +43,9 @@ static int sharp_lq_panel_power_on(struct omap_dss_device *dssdev)
>> {
>> int r;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> r = omapdss_dpi_display_enable(dssdev);
>> if (r)
>> goto err0;
>> @@ -65,6 +68,9 @@ err0:
>>
>> static void sharp_lq_panel_power_off(struct omap_dss_device *dssdev)
>> {
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> if (dssdev->platform_disable)
>> dssdev->platform_disable(dssdev);
>>
>> diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>> index 7d9eb2b..9a138f6 100644
>> --- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>> +++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>> @@ -135,6 +135,9 @@ static int sharp_ls_power_on(struct omap_dss_device *dssdev)
>> {
>> int r = 0;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> r = omapdss_dpi_display_enable(dssdev);
>> if (r)
>> goto err0;
>> @@ -157,6 +160,9 @@ err0:
>>
>> static void sharp_ls_power_off(struct omap_dss_device *dssdev)
>> {
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> if (dssdev->platform_disable)
>> dssdev->platform_disable(dssdev);
>>
>> diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
>> index aaf5d30..c649f06 100644
>> --- a/drivers/video/omap2/displays/panel-taal.c
>> +++ b/drivers/video/omap2/displays/panel-taal.c
>> @@ -635,6 +635,9 @@ static int taal_power_on(struct omap_dss_device *dssdev)
>> u8 id1, id2, id3;
>> int r;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> if (dssdev->platform_enable) {
>> r = dssdev->platform_enable(dssdev);
>> if (r)
>> @@ -715,6 +718,9 @@ static void taal_power_off(struct omap_dss_device *dssdev)
>> {
>> struct taal_data *td = dev_get_drvdata(&dssdev->dev);
>>
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> dsi_bus_lock();
>>
>> cancel_delayed_work(&td->esd_work);
>> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>> index fa434ca..49e1dec 100644
>> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>> @@ -46,6 +46,9 @@ static int toppoly_tdo_panel_power_on(struct omap_dss_device *dssdev)
>> {
>> int r;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> r = omapdss_dpi_display_enable(dssdev);
>> if (r)
>> goto err0;
>> @@ -65,6 +68,9 @@ err0:
>>
>> static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
>> {
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> if (dssdev->platform_disable)
>> dssdev->platform_disable(dssdev);
>>
>> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>> index e866e76..dbe9d43 100644
>> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>> @@ -269,6 +269,9 @@ static int tpo_td043_power_on(struct omap_dss_device *dssdev)
>> int nreset_gpio = dssdev->reset_gpio;
>> int r;
>>
>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>> + return 0;
>> +
>> r = omapdss_dpi_display_enable(dssdev);
>> if (r)
>> goto err0;
>> @@ -308,6 +311,9 @@ static void tpo_td043_power_off(struct omap_dss_device *dssdev)
>> struct tpo_td043_device *tpo_td043 = dev_get_drvdata(&dssdev->dev);
>> int nreset_gpio = dssdev->reset_gpio;
>>
>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>> + return;
>> +
>> tpo_td043_write(tpo_td043->spi, 3,
>> TPO_R03_VAL_STANDBY | TPO_R03_EN_PWM);
>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-17 9:01 ` Bryan Wu
@ 2010-08-17 9:27 ` stanley.miao
2010-08-17 9:48 ` Bryan Wu
0 siblings, 1 reply; 8+ messages in thread
From: stanley.miao @ 2010-08-17 9:27 UTC (permalink / raw)
To: bryan.wu; +Cc: linux-omap, lwalkera, lwalkera, tomi.valkeinen, linux-fbdev
It should be Tomi to maintain DSS2. I didn't get any response from Tomi.
Stanley.
Bryan Wu wrote:
> Is there any feedback about this patch,
>
> Tested-by: Bryan Wu <bryan.wu@canonical.com>
>
> -Bryan
>
> On 08/11/2010 02:50 PM, Bryan Wu wrote:
>
>> Tested on my Beagle board. It fixed the issue.
>>
>> Thanks,
>> -Bryan
>>
>> On 08/11/2010 11:19 AM, Stanley.Miao wrote:
>>
>>> If we blank the panel by
>>> echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
>>>
>>> Then, we reboot the sytem, the kernel will crash at
>>> drivers/video/omap2/dss/core.c:323
>>>
>>> This is because the panel is closed twice. Now check the state of a dssdev
>>> to forbid a panel is power on or power off twice.
>>>
>>> Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
>>> ---
>>> drivers/video/omap2/displays/panel-acx565akm.c | 6 ++++++
>>> drivers/video/omap2/displays/panel-generic.c | 6 ++++++
>>> .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 6 ++++++
>>> .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 6 ++++++
>>> drivers/video/omap2/displays/panel-taal.c | 6 ++++++
>>> .../video/omap2/displays/panel-toppoly-tdo35s.c | 6 ++++++
>>> .../video/omap2/displays/panel-tpo-td043mtea1.c | 6 ++++++
>>> 7 files changed, 42 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
>>> index 1f8eb70..374cbeb 100644
>>> --- a/drivers/video/omap2/displays/panel-acx565akm.c
>>> +++ b/drivers/video/omap2/displays/panel-acx565akm.c
>>> @@ -587,6 +587,9 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev)
>>>
>>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> mutex_lock(&md->mutex);
>>>
>>> r = omapdss_sdi_display_enable(dssdev);
>>> @@ -642,6 +645,9 @@ static void acx_panel_power_off(struct omap_dss_device *dssdev)
>>>
>>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>>
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> mutex_lock(&md->mutex);
>>>
>>> if (!md->enabled) {
>>> diff --git a/drivers/video/omap2/displays/panel-generic.c b/drivers/video/omap2/displays/panel-generic.c
>>> index 300eff5..395a68d 100644
>>> --- a/drivers/video/omap2/displays/panel-generic.c
>>> +++ b/drivers/video/omap2/displays/panel-generic.c
>>> @@ -39,6 +39,9 @@ static int generic_panel_power_on(struct omap_dss_device *dssdev)
>>> {
>>> int r;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> r = omapdss_dpi_display_enable(dssdev);
>>> if (r)
>>> goto err0;
>>> @@ -58,6 +61,9 @@ err0:
>>>
>>> static void generic_panel_power_off(struct omap_dss_device *dssdev)
>>> {
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> if (dssdev->platform_disable)
>>> dssdev->platform_disable(dssdev);
>>>
>>> diff --git a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>> index 1026746..0c6896c 100644
>>> --- a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>> +++ b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>> @@ -43,6 +43,9 @@ static int sharp_lq_panel_power_on(struct omap_dss_device *dssdev)
>>> {
>>> int r;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> r = omapdss_dpi_display_enable(dssdev);
>>> if (r)
>>> goto err0;
>>> @@ -65,6 +68,9 @@ err0:
>>>
>>> static void sharp_lq_panel_power_off(struct omap_dss_device *dssdev)
>>> {
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> if (dssdev->platform_disable)
>>> dssdev->platform_disable(dssdev);
>>>
>>> diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>> index 7d9eb2b..9a138f6 100644
>>> --- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>> +++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>> @@ -135,6 +135,9 @@ static int sharp_ls_power_on(struct omap_dss_device *dssdev)
>>> {
>>> int r = 0;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> r = omapdss_dpi_display_enable(dssdev);
>>> if (r)
>>> goto err0;
>>> @@ -157,6 +160,9 @@ err0:
>>>
>>> static void sharp_ls_power_off(struct omap_dss_device *dssdev)
>>> {
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> if (dssdev->platform_disable)
>>> dssdev->platform_disable(dssdev);
>>>
>>> diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
>>> index aaf5d30..c649f06 100644
>>> --- a/drivers/video/omap2/displays/panel-taal.c
>>> +++ b/drivers/video/omap2/displays/panel-taal.c
>>> @@ -635,6 +635,9 @@ static int taal_power_on(struct omap_dss_device *dssdev)
>>> u8 id1, id2, id3;
>>> int r;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> if (dssdev->platform_enable) {
>>> r = dssdev->platform_enable(dssdev);
>>> if (r)
>>> @@ -715,6 +718,9 @@ static void taal_power_off(struct omap_dss_device *dssdev)
>>> {
>>> struct taal_data *td = dev_get_drvdata(&dssdev->dev);
>>>
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> dsi_bus_lock();
>>>
>>> cancel_delayed_work(&td->esd_work);
>>> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>> index fa434ca..49e1dec 100644
>>> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>> @@ -46,6 +46,9 @@ static int toppoly_tdo_panel_power_on(struct omap_dss_device *dssdev)
>>> {
>>> int r;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> r = omapdss_dpi_display_enable(dssdev);
>>> if (r)
>>> goto err0;
>>> @@ -65,6 +68,9 @@ err0:
>>>
>>> static void toppoly_tdo_panel_power_off(struct omap_dss_device *dssdev)
>>> {
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> if (dssdev->platform_disable)
>>> dssdev->platform_disable(dssdev);
>>>
>>> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>> index e866e76..dbe9d43 100644
>>> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>> @@ -269,6 +269,9 @@ static int tpo_td043_power_on(struct omap_dss_device *dssdev)
>>> int nreset_gpio = dssdev->reset_gpio;
>>> int r;
>>>
>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>> + return 0;
>>> +
>>> r = omapdss_dpi_display_enable(dssdev);
>>> if (r)
>>> goto err0;
>>> @@ -308,6 +311,9 @@ static void tpo_td043_power_off(struct omap_dss_device *dssdev)
>>> struct tpo_td043_device *tpo_td043 = dev_get_drvdata(&dssdev->dev);
>>> int nreset_gpio = dssdev->reset_gpio;
>>>
>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>> + return;
>>> +
>>> tpo_td043_write(tpo_td043->spi, 3,
>>> TPO_R03_VAL_STANDBY | TPO_R03_EN_PWM);
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-17 9:27 ` stanley.miao
@ 2010-08-17 9:48 ` Bryan Wu
0 siblings, 0 replies; 8+ messages in thread
From: Bryan Wu @ 2010-08-17 9:48 UTC (permalink / raw)
To: stanley.miao; +Cc: linux-omap, lwalkera, lwalkera, tomi.valkeinen, linux-fbdev
I can also reproduce it when I try to use kexec to reboot the system. And this
patch fix that.
-Bryan
On 08/17/2010 05:27 PM, stanley.miao wrote:
> It should be Tomi to maintain DSS2. I didn't get any response from Tomi.
>
> Stanley.
>
> Bryan Wu wrote:
>> Is there any feedback about this patch,
>>
>> Tested-by: Bryan Wu <bryan.wu@canonical.com>
>>
>> -Bryan
>>
>> On 08/11/2010 02:50 PM, Bryan Wu wrote:
>>
>>> Tested on my Beagle board. It fixed the issue.
>>>
>>> Thanks,
>>> -Bryan
>>>
>>> On 08/11/2010 11:19 AM, Stanley.Miao wrote:
>>>
>>>> If we blank the panel by
>>>> echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
>>>>
>>>> Then, we reboot the sytem, the kernel will crash at
>>>> drivers/video/omap2/dss/core.c:323
>>>>
>>>> This is because the panel is closed twice. Now check the state of a
>>>> dssdev
>>>> to forbid a panel is power on or power off twice.
>>>>
>>>> Signed-off-by: Stanley.Miao <stanley.miao@windriver.com>
>>>> ---
>>>> drivers/video/omap2/displays/panel-acx565akm.c | 6 ++++++
>>>> drivers/video/omap2/displays/panel-generic.c | 6 ++++++
>>>> .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 6 ++++++
>>>> .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 6 ++++++
>>>> drivers/video/omap2/displays/panel-taal.c | 6 ++++++
>>>> .../video/omap2/displays/panel-toppoly-tdo35s.c | 6 ++++++
>>>> .../video/omap2/displays/panel-tpo-td043mtea1.c | 6 ++++++
>>>> 7 files changed, 42 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/video/omap2/displays/panel-acx565akm.c
>>>> b/drivers/video/omap2/displays/panel-acx565akm.c
>>>> index 1f8eb70..374cbeb 100644
>>>> --- a/drivers/video/omap2/displays/panel-acx565akm.c
>>>> +++ b/drivers/video/omap2/displays/panel-acx565akm.c
>>>> @@ -587,6 +587,9 @@ static int acx_panel_power_on(struct
>>>> omap_dss_device *dssdev)
>>>>
>>>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> mutex_lock(&md->mutex);
>>>>
>>>> r = omapdss_sdi_display_enable(dssdev);
>>>> @@ -642,6 +645,9 @@ static void acx_panel_power_off(struct
>>>> omap_dss_device *dssdev)
>>>>
>>>> dev_dbg(&dssdev->dev, "%s\n", __func__);
>>>>
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> mutex_lock(&md->mutex);
>>>>
>>>> if (!md->enabled) {
>>>> diff --git a/drivers/video/omap2/displays/panel-generic.c
>>>> b/drivers/video/omap2/displays/panel-generic.c
>>>> index 300eff5..395a68d 100644
>>>> --- a/drivers/video/omap2/displays/panel-generic.c
>>>> +++ b/drivers/video/omap2/displays/panel-generic.c
>>>> @@ -39,6 +39,9 @@ static int generic_panel_power_on(struct
>>>> omap_dss_device *dssdev)
>>>> {
>>>> int r;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> r = omapdss_dpi_display_enable(dssdev);
>>>> if (r)
>>>> goto err0;
>>>> @@ -58,6 +61,9 @@ err0:
>>>>
>>>> static void generic_panel_power_off(struct omap_dss_device *dssdev)
>>>> {
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> if (dssdev->platform_disable)
>>>> dssdev->platform_disable(dssdev);
>>>>
>>>> diff --git a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>>> b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>>> index 1026746..0c6896c 100644
>>>> --- a/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>>> +++ b/drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
>>>> @@ -43,6 +43,9 @@ static int sharp_lq_panel_power_on(struct
>>>> omap_dss_device *dssdev)
>>>> {
>>>> int r;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> r = omapdss_dpi_display_enable(dssdev);
>>>> if (r)
>>>> goto err0;
>>>> @@ -65,6 +68,9 @@ err0:
>>>>
>>>> static void sharp_lq_panel_power_off(struct omap_dss_device *dssdev)
>>>> {
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> if (dssdev->platform_disable)
>>>> dssdev->platform_disable(dssdev);
>>>>
>>>> diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>>> b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>>> index 7d9eb2b..9a138f6 100644
>>>> --- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>>> +++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c
>>>> @@ -135,6 +135,9 @@ static int sharp_ls_power_on(struct
>>>> omap_dss_device *dssdev)
>>>> {
>>>> int r = 0;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> r = omapdss_dpi_display_enable(dssdev);
>>>> if (r)
>>>> goto err0;
>>>> @@ -157,6 +160,9 @@ err0:
>>>>
>>>> static void sharp_ls_power_off(struct omap_dss_device *dssdev)
>>>> {
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> if (dssdev->platform_disable)
>>>> dssdev->platform_disable(dssdev);
>>>>
>>>> diff --git a/drivers/video/omap2/displays/panel-taal.c
>>>> b/drivers/video/omap2/displays/panel-taal.c
>>>> index aaf5d30..c649f06 100644
>>>> --- a/drivers/video/omap2/displays/panel-taal.c
>>>> +++ b/drivers/video/omap2/displays/panel-taal.c
>>>> @@ -635,6 +635,9 @@ static int taal_power_on(struct omap_dss_device
>>>> *dssdev)
>>>> u8 id1, id2, id3;
>>>> int r;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> if (dssdev->platform_enable) {
>>>> r = dssdev->platform_enable(dssdev);
>>>> if (r)
>>>> @@ -715,6 +718,9 @@ static void taal_power_off(struct
>>>> omap_dss_device *dssdev)
>>>> {
>>>> struct taal_data *td = dev_get_drvdata(&dssdev->dev);
>>>>
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> dsi_bus_lock();
>>>>
>>>> cancel_delayed_work(&td->esd_work);
>>>> diff --git a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>>> b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>>> index fa434ca..49e1dec 100644
>>>> --- a/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>>> +++ b/drivers/video/omap2/displays/panel-toppoly-tdo35s.c
>>>> @@ -46,6 +46,9 @@ static int toppoly_tdo_panel_power_on(struct
>>>> omap_dss_device *dssdev)
>>>> {
>>>> int r;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> r = omapdss_dpi_display_enable(dssdev);
>>>> if (r)
>>>> goto err0;
>>>> @@ -65,6 +68,9 @@ err0:
>>>>
>>>> static void toppoly_tdo_panel_power_off(struct omap_dss_device
>>>> *dssdev)
>>>> {
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> if (dssdev->platform_disable)
>>>> dssdev->platform_disable(dssdev);
>>>>
>>>> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>>> b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>>> index e866e76..dbe9d43 100644
>>>> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>>> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>>>> @@ -269,6 +269,9 @@ static int tpo_td043_power_on(struct
>>>> omap_dss_device *dssdev)
>>>> int nreset_gpio = dssdev->reset_gpio;
>>>> int r;
>>>>
>>>> + if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return 0;
>>>> +
>>>> r = omapdss_dpi_display_enable(dssdev);
>>>> if (r)
>>>> goto err0;
>>>> @@ -308,6 +311,9 @@ static void tpo_td043_power_off(struct
>>>> omap_dss_device *dssdev)
>>>> struct tpo_td043_device *tpo_td043 =
>>>> dev_get_drvdata(&dssdev->dev);
>>>> int nreset_gpio = dssdev->reset_gpio;
>>>>
>>>> + if (dssdev->state != OMAP_DSS_DISPLAY_ACTIVE)
>>>> + return;
>>>> +
>>>> tpo_td043_write(tpo_td043->spi, 3,
>>>> TPO_R03_VAL_STANDBY | TPO_R03_EN_PWM);
>>>>
>>>>
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-11 3:19 [PATCH V2] OMAP: DSS2: don't power off a panel twice Stanley.Miao
2010-08-11 6:50 ` Bryan Wu
@ 2010-08-17 10:34 ` Tomi Valkeinen
2010-09-03 2:52 ` stanley.miao
1 sibling, 1 reply; 8+ messages in thread
From: Tomi Valkeinen @ 2010-08-17 10:34 UTC (permalink / raw)
To: ext Stanley.Miao
Cc: linux-omap@vger.kernel.org, lwalkera@ieee.org, lwalkera@gmail.com
Hi,
On Wed, 2010-08-11 at 05:19 +0200, ext Stanley.Miao wrote:
> If we blank the panel by
> echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
>
> Then, we reboot the sytem, the kernel will crash at
> drivers/video/omap2/dss/core.c:323
>
> This is because the panel is closed twice. Now check the state of a dssdev
> to forbid a panel is power on or power off twice.
Otherwise this looks fine, except that panel-taal.c does not need
modifications, as it already handles this case.
Also, at some point I (or somebody else =) should think how to do proper
locking for the panel drivers. Currently it's rather broken, and, for
example, enabling and disabling a panel at the same time will cause
problems. Except for panel-taal, which uses its own lock.
Tomi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-08-17 10:34 ` Tomi Valkeinen
@ 2010-09-03 2:52 ` stanley.miao
2010-10-21 13:42 ` Tomi Valkeinen
0 siblings, 1 reply; 8+ messages in thread
From: stanley.miao @ 2010-09-03 2:52 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: linux-omap@vger.kernel.org, lwalkera@ieee.org, lwalkera@gmail.com,
bryan.wu, Mathieu Poirier
Hi, Tomi,
Tomi Valkeinen wrote:
> <snip>
>
> Otherwise this looks fine, except that panel-taal.c does not need
> modifications, as it already handles this case.
>
I will send a V3 to remove the panel-taal.c part.
> Also, at some point I (or somebody else =) should think how to do proper
> locking for the panel drivers. Currently it's rather broken, and, for
> example, enabling and disabling a panel at the same time will cause
> problems. Except for panel-taal, which uses its own lock.
>
First, I don't think there is any occasion where you need to enable and
disable a panel at the same time.
If so, what kind of result do you want ? enabled or disabled ?
Second, now the dssdev->state can do the lock job properly. It can
ensure only one function can run if both disable()
and enable are called at the same time.
Stanley.
> Tomi
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] OMAP: DSS2: don't power off a panel twice
2010-09-03 2:52 ` stanley.miao
@ 2010-10-21 13:42 ` Tomi Valkeinen
0 siblings, 0 replies; 8+ messages in thread
From: Tomi Valkeinen @ 2010-10-21 13:42 UTC (permalink / raw)
To: ext stanley.miao
Cc: linux-omap@vger.kernel.org, lwalkera@ieee.org, lwalkera@gmail.com,
bryan.wu@canonical.com, Mathieu Poirier
Hi,
On Fri, 2010-09-03 at 04:52 +0200, ext stanley.miao wrote:
> Hi, Tomi,
>
> Tomi Valkeinen wrote:
> > <snip>
> >
> > Otherwise this looks fine, except that panel-taal.c does not need
> > modifications, as it already handles this case.
> >
>
> I will send a V3 to remove the panel-taal.c part.
>
> > Also, at some point I (or somebody else =) should think how to do proper
> > locking for the panel drivers. Currently it's rather broken, and, for
> > example, enabling and disabling a panel at the same time will cause
> > problems. Except for panel-taal, which uses its own lock.
> >
>
> First, I don't think there is any occasion where you need to enable and
> disable a panel at the same time.
No, but that doesn't mean that enable and disable won't be called at the
same time.
> If so, what kind of result do you want ? enabled or disabled ?
Enabled or disabled, but not crashing or bugging display.
> Second, now the dssdev->state can do the lock job properly. It can
> ensure only one function can run if both disable()
> and enable are called at the same time.
It doesn't do any kind of locking, it just checks the variable. enable
and disable can still be run at the same time.
Tomi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-21 13:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-11 3:19 [PATCH V2] OMAP: DSS2: don't power off a panel twice Stanley.Miao
2010-08-11 6:50 ` Bryan Wu
2010-08-17 9:01 ` Bryan Wu
2010-08-17 9:27 ` stanley.miao
2010-08-17 9:48 ` Bryan Wu
2010-08-17 10:34 ` Tomi Valkeinen
2010-09-03 2:52 ` stanley.miao
2010-10-21 13:42 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).