Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

Tony Lindgren
2010-10-01T17:02:19Z

* Jarkko Nikula <jhnikula@gmail.com> [101001 04:34]:
> On Fri, 1 Oct 2010 16:39:42 +0530
> "G, Manjunath Kondaiah" <manjugk@ti.com> wrote:
>
> > > On Friday 01 October 2010 12:29:54 ext G, Manjunath Kondaiah wrote:
> > > > > But yes, it would make the code much more readable, and we can
> > > > > easily track, which errata has been already addressed.
> > > >
> > > > This is already done as a part of dma hwmod which is under review.
> > >
> > > OK, so we shall not bother with this in the 'legacy' code, right?
> > >
> >
> > That's correct but these patches needs to be ported on top of dma
> > driver with hwmod changes.
> >
> Priority must be opposite. Hwmod change is upcoming cleanup but these
> two patches are fixing existing problem.

That's right, fixes are the highest priority and we need to get those
into the mainline kernel ASAP. Otherwise there will be insane amounts
of wasted duplicate effort with people tracking the same bugs over
and over again like we've seen with omap over the years.

If you have fixes, get them into the mainline kernel.

Do not pile up fixes in some development tree where nobody will
find them.

Regards,

Tony