Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

Peter Ujfalusi
2010-10-01T08:52:07Z

On Friday 01 October 2010 10:45:12 ext Nishanth Menon wrote:
...
> > - l &= ~OMAP_DMA_CCR_EN;
> > - dma_write(l, CCR(lch));
> > + /* OMAP3 Errata: sDMA FIFO draining does not finish */
>
> would be informative to give the iXYZ id as well for some of these
> erratas might scale across processors.

In TI's site I was only able to find this public ERRATA:
OMAP3530/25/15/03 Applications Processor Silicon Errata-Revs 3.1, 3.0, 2.1,&2.0
(Rev. E)
In that document it is under: Advisory 3.1.1.192, but no iXYZ is associated with
it. However I have another ERRATA document, which has the iXYZ associated with
this advisory, but the first page tells that it is confidential, and under NDA
restriction. I'm not really sure, if I should refere to that number...
But if you have the iXYZ number, which I can use, than I'm more than happy to
add that.

> > + if (cpu_is_omap34xx() && (l & OMAP_DMA_CCR_SEL_SRC_DST_SYNC)) {
>
> does it make sense to use an dma_errata variable and populate it?

Hmmm, the errata handling via dma_errata shall be done separately IMHO,
since if we do that, than we need to revisit other parts of the code as well,
and replace the existing errata handling.

But yes, it would make the code much more readable, and we can easily track,
which errata has been already addressed.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html