Re: [PATCH 1/2] omap: dma: Fix buffering disable bit setting for omap24xx

Nishanth Menon
2010-10-01T08:21:17Z

Peter Ujfalusi had written, on 10/01/2010 01:39 AM, the following:
[...]
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index ec7eddf..7115884 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -1000,7 +1000,7 @@ void omap_start_dma(int lch)
> * This will always fail on ES1.0
> */
> if (cpu_is_omap24xx())
> - l |= OMAP_DMA_CCR_EN;
in code comment for errata helps over time I guess.. could be my pet peeve.
> + l |= OMAP_DMA_CCR_BUFFERING_DISABLE;

same comment -> would be nice to have erratas under a errata variable to
help track them all..
[...]
--
Regards,
Nishanth Menon