Re: [PATCH 1/2] omap: dma: Fix buffering disable bit setting for omap24xx

Jarkko Nikula
2010-10-01T09:20:16Z

On Fri, 1 Oct 2010 02:47:10 -0500
Nishanth Menon <nm@ti.com> wrote:

> Peter Ujfalusi had written, on 10/01/2010 01:39 AM, the following:
> [...]
> > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> > index ec7eddf..7115884 100644
> > --- a/arch/arm/plat-omap/dma.c
> > +++ b/arch/arm/plat-omap/dma.c
> > @@ -1000,7 +1000,7 @@ void omap_start_dma(int lch)
> > * This will always fail on ES1.0
> > */
> > if (cpu_is_omap24xx())
> > - l |= OMAP_DMA_CCR_EN;
> in code comment for errata helps over time I guess.. could be my pet peeve.
> > + l |= OMAP_DMA_CCR_BUFFERING_DISABLE;
>
Definitely. Unfortunately I don't have a 24xx TRM or errata so I cannot
check it. This workaround was introduced by a commit 1a8bfa so I think
it originated from pre-git history or from some inhouse tree.

--
Jarkko