RE: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

G, Manjunath Kondaiah
2010-10-01T09:30:07Z

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Peter Ujfalusi
> Sent: Friday, October 01, 2010 2:22 PM
> To: Menon, Nishanth
> Cc: Tony Lindgren; linux-omap@vger.kernel.org; Jarkko Nikula;
> Liam Girdwood
> Subject: Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO
> draining does not finish
...

>
> > > + if (cpu_is_omap34xx() && (l & OMAP_DMA_CCR_SEL_SRC_DST_SYNC)) {
> >
> > does it make sense to use an dma_errata variable and populate it?
>
> Hmmm, the errata handling via dma_errata shall be done
> separately IMHO, since if we do that, than we need to revisit
> other parts of the code as well, and replace the existing
> errata handling.
>
> But yes, it would make the code much more readable, and we
> can easily track, which errata has been already addressed.
>

This is already done as a part of dma hwmod which is under review.

-Manjunath