Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish

Jarkko Nikula
2010-10-01T11:43:25Z

On Fri, 1 Oct 2010 16:39:42 +0530
"G, Manjunath Kondaiah" <manjugk@ti.com> wrote:

> > On Friday 01 October 2010 12:29:54 ext G, Manjunath Kondaiah wrote:
> > > > But yes, it would make the code much more readable, and we can
> > > > easily track, which errata has been already addressed.
> > >
> > > This is already done as a part of dma hwmod which is under review.
> >
> > OK, so we shall not bother with this in the 'legacy' code, right?
> >
>
> That's correct but these patches needs to be ported on top of dma
> driver with hwmod changes.
>
Priority must be opposite. Hwmod change is upcoming cleanup but these
two patches are fixing existing problem.

Problem has been there probably quite some time but we were able to see
it only after a proper use-case. Which is buffer overrun when doing
audio recording only and after the commit c12abc0 (in 2.6.32).

--
Jarkko