From: Nishanth Menon <nm@ti.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Jarkko Nikula <jhnikula@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish
Date: Fri, 1 Oct 2010 04:43:22 -0500 [thread overview]
Message-ID: <4CA5AD3A.50700@ti.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB90C2C0@dbde02.ent.ti.com>
G, Manjunath Kondaiah had written, on 10/01/2010 04:29 AM, the following:
>
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org
>> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Peter Ujfalusi
>> Sent: Friday, October 01, 2010 2:22 PM
>> To: Menon, Nishanth
>> Cc: Tony Lindgren; linux-omap@vger.kernel.org; Jarkko Nikula;
>> Liam Girdwood
>> Subject: Re: [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO
>> draining does not finish
> ...
>
>>>> + if (cpu_is_omap34xx() && (l & OMAP_DMA_CCR_SEL_SRC_DST_SYNC)) {
>>> does it make sense to use an dma_errata variable and populate it?
>> Hmmm, the errata handling via dma_errata shall be done
>> separately IMHO, since if we do that, than we need to revisit
>> other parts of the code as well, and replace the existing
>> errata handling.
>>
>> But yes, it would make the code much more readable, and we
>> can easily track, which errata has been already addressed.
>>
>
> This is already done as a part of dma hwmod which is under review.
>
> -Manjunath
Apologies, but does that mean:
a) the errata i541 is handled as well as part of hwmod series?
b) the patch needs to be ported ontop of hwmod series?
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-10-01 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 6:39 [PATCH 0/2] OMAP2/3: DMA: FIFO drain errata fixes Peter Ujfalusi
2010-10-01 6:39 ` [PATCH 1/2] omap: dma: Fix buffering disable bit setting for omap24xx Peter Ujfalusi
2010-10-01 7:47 ` Nishanth Menon
2010-10-01 9:20 ` Jarkko Nikula
2010-10-01 6:39 ` [PATCH 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish Peter Ujfalusi
2010-10-01 7:00 ` Jarkko Nikula
2010-10-01 7:45 ` Nishanth Menon
2010-10-01 8:51 ` Peter Ujfalusi
2010-10-01 9:23 ` Nishanth Menon
2010-10-01 10:40 ` Peter Ujfalusi
2010-10-01 9:29 ` G, Manjunath Kondaiah
2010-10-01 9:43 ` Nishanth Menon [this message]
2010-10-01 9:45 ` G, Manjunath Kondaiah
2010-10-01 10:43 ` Peter Ujfalusi
2010-10-01 10:41 ` Peter Ujfalusi
2010-10-01 11:09 ` G, Manjunath Kondaiah
2010-10-01 11:43 ` Jarkko Nikula
2010-10-01 11:48 ` Jarkko Nikula
2010-10-01 17:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA5AD3A.50700@ti.com \
--to=nm@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=manjugk@ti.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox