From: Anand Gadiyar <gadiyar@ti.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: tomi.valkeinen@nokia.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] OMAP: DSS2: introduce dummy panel driver
Date: Tue, 02 Nov 2010 22:23:51 +0530 [thread overview]
Message-ID: <4CD0421F.5070200@ti.com> (raw)
In-Reply-To: <1288714390-6159-1-git-send-email-bryan.wu@canonical.com>
On 11/2/2010 9:43 PM, Bryan Wu wrote:
> There are 4 duplicated panel driver sin DSS2 display driver. They are similar
> and dummy panel driver can support all them with specific panel configuration.
> And new panel driver can be easily supported by adding panel configurations
> into dummy panel driver.
>
> This patchset introduces dummy panel driver, remove 3 panel drivers and enable
> dummy panel driver in board files. And it is based on 2.6.37-rc1.
>
> Building with omap2plus_defconfig is successful.
>
> Keep sharp_ls_panel, since it contains blacklight control code which will be
> moved out later.
>
> Bryan Wu (3):
> OMAP: DSS2: Add dummy panel display driver
> OMAP: DSS2: remove dummy panel driver duplicated panel drivers
> OMAP: use dummy panel driver in board files
>
> arch/arm/mach-omap2/board-3430sdp.c | 3 +-
> arch/arm/mach-omap2/board-am3517evm.c | 6 +-
> arch/arm/mach-omap2/board-cm-t35.c | 6 +-
> arch/arm/mach-omap2/board-devkit8000.c | 6 +-
> arch/arm/mach-omap2/board-igep0020.c | 3 +-
> arch/arm/mach-omap2/board-omap3beagle.c | 3 +-
> arch/arm/mach-omap2/board-omap3evm.c | 3 +-
> arch/arm/mach-omap2/board-omap3stalker.c | 6 +-
> arch/arm/plat-omap/include/plat/display.h | 28 +-
> drivers/video/omap2/displays/Kconfig | 22 +-
> drivers/video/omap2/displays/Makefile | 4 +-
> drivers/video/omap2/displays/panel-dummy.c | 195 +++++++
> drivers/video/omap2/displays/panel-dummy.h | 119 +++++
> drivers/video/omap2/displays/panel-generic.c | 174 -------
> .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 165 ------
> .../video/omap2/displays/panel-tpo-td043mtea1.c | 535 --------------------
> 16 files changed, 364 insertions(+), 914 deletions(-)
> create mode 100644 drivers/video/omap2/displays/panel-dummy.c
> create mode 100644 drivers/video/omap2/displays/panel-dummy.h
> delete mode 100644 drivers/video/omap2/displays/panel-generic.c
> delete mode 100644 drivers/video/omap2/displays/panel-sharp-lq043t1dg01.c
> delete mode 100644 drivers/video/omap2/displays/panel-tpo-td043mtea1.c
>
Why can't panel-generic.c be reused instead of a new panel-dummy.c?
Sounds like what you're trying to do is to get a generic panel driver;
so shouldn't it at least be called generic instead of dummy.
- Anand
next prev parent reply other threads:[~2010-11-02 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 16:13 [PATCH 0/3] OMAP: DSS2: introduce dummy panel driver Bryan Wu
2010-11-02 16:13 ` [PATCH 1/3] OMAP: DSS2: Add dummy panel display driver Bryan Wu
2010-11-02 17:21 ` Grazvydas Ignotas
2010-11-02 19:13 ` Bryan Wu
2010-11-02 16:13 ` [PATCH 2/3] OMAP: DSS2: remove dummy panel driver duplicated panel drivers Bryan Wu
2010-11-02 17:11 ` Grazvydas Ignotas
2010-11-02 16:13 ` [PATCH 3/3] OMAP: use dummy panel driver in board files Bryan Wu
2010-11-02 16:53 ` Anand Gadiyar [this message]
2010-11-02 19:12 ` [PATCH 0/3] OMAP: DSS2: introduce dummy panel driver Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD0421F.5070200@ti.com \
--to=gadiyar@ti.com \
--cc=bryan.wu@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox