From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
Russell King <linux@arm.linux.org.uk>,
Felipe Contreras <felipe.contreras@gmail.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Anna, Suman" <s-anna@ti.com>, Paul Walmsley <paul@pwsan.com>,
"Raja, Govindraj" <govindraj.raja@ti.com>,
"Varadarajan, Charulatha" <charu@ti.com>,
"C.A, Subramaniam" <subramaniam.ca@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 0/7] omap: mailbox: hwmod support and dependent cleanup patches
Date: Sat, 06 Nov 2010 14:32:45 -0400 [thread overview]
Message-ID: <4CD59F4D.8070903@ti.com> (raw)
In-Reply-To: <1289006244-27147-1-git-send-email-omar.ramirez@ti.com>
On 11/5/2010 9:17 PM, Ramirez Luna, Omar wrote:
> hwmod support for omap2 and omap3 chips, plus cleanups.
>
> Tested on 3430 and 3630
>
> ** v2 **
> - Added omap4 hwmod support.
> - Moved "mailbox_ick" from hwmod to hwmod_if (omap 2/3)
> - Declared sysc classes for omap 2/3
>
> ** v1 **
> 1. omap: mailbox: initial hwmod support for omap3
> Changes were made to:
> - Rebase to latest code.
> - Detect the hwmod by filling prcm union for omap2, without
> this it was unable to build the hwmod at runtime.
> - Replace magic number for defines.
> - Use ioremap again instead of relying on the one made by hwmod,
> as noted in http://patchwork.kernel.org/patch/101661/
>
> 2. omap: mailbox: initial hwmod support for omap2
> Was only compiled tested!! Unfortunately I don't have the HW for it.
>
> 4. omap: mailbox: fix detection for previously supported chips
> Original patch was using features framework, but when compiled as a module
> it was breaking, this patch uses cpu_is_omap34xx macro instead. This is
> meant as a short term solution until proper cleanup is done, as suggested in:
>
> http://marc.info/?l=linux-arm-kernel&m=128534253231481&w=2
>
> Benoit Cousson (1):
> OMAP4: hwmod data: add mailbox data
>
> Felipe Contreras (3):
> OMAP3: hwmod data: add mailbox data
> omap: mailbox: initial hwmod support
> omap: mailbox: add omap_device latency information
Could you please try to use a consistent naming in the subject?
You use OMAP3, OMAP4, OMAP2 so it should be OMAP and not omap.
Thanks,
Benoit
>
> Omar Ramirez Luna (3):
> OMAP2: hwmod data: add mailbox data
> omap: mailbox: fix detection for previously supported chips
> omap: mailbox: remove unreachable return
>
> arch/arm/mach-omap2/devices.c | 104 +++++++---------------------
> arch/arm/mach-omap2/mailbox.c | 39 +++++-----
> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 67 ++++++++++++++++++
> arch/arm/mach-omap2/omap_hwmod_2430_data.c | 66 ++++++++++++++++++
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 66 ++++++++++++++++++
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 63 +++++++++++++++++
> arch/arm/plat-omap/include/plat/mailbox.h | 6 ++
> 7 files changed, 311 insertions(+), 100 deletions(-)
>
next prev parent reply other threads:[~2010-11-06 18:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 1:17 [PATCH v2 0/7] omap: mailbox: hwmod support and dependent cleanup patches Omar Ramirez Luna
2010-11-06 1:17 ` [PATCH v2 1/7] OMAP2: hwmod data: add mailbox data Omar Ramirez Luna
2010-11-06 17:08 ` Cousson, Benoit
2010-11-07 14:27 ` Ramirez Luna, Omar
2010-11-06 1:17 ` [PATCH v2 2/7] OMAP3: " Omar Ramirez Luna
2010-11-06 1:17 ` [PATCH v2 3/7] OMAP4: " Omar Ramirez Luna
2010-11-06 17:18 ` Cousson, Benoit
2010-11-07 15:07 ` Ramirez Luna, Omar
2010-11-08 8:56 ` Cousson, Benoit
2010-11-08 16:55 ` Ramirez Luna, Omar
2010-11-06 1:17 ` [PATCH v2 4/7] omap: mailbox: initial hwmod support Omar Ramirez Luna
2010-11-06 17:44 ` Cousson, Benoit
2010-11-06 1:17 ` [PATCH v2 5/7] omap: mailbox: add omap_device latency information Omar Ramirez Luna
2010-11-06 18:09 ` Cousson, Benoit
2010-11-06 1:17 ` [PATCH v2 6/7] omap: mailbox: fix detection for previously supported chips Omar Ramirez Luna
2010-11-06 18:11 ` Cousson, Benoit
2010-11-07 15:15 ` Ramirez Luna, Omar
2010-11-07 21:05 ` Felipe Contreras
2010-11-08 16:05 ` Ramirez Luna, Omar
2010-11-08 21:43 ` Cousson, Benoit
2010-11-06 1:17 ` [PATCH v2 7/7] omap: mailbox: remove unreachable return Omar Ramirez Luna
2010-11-06 18:21 ` Cousson, Benoit
2010-11-07 15:18 ` Ramirez Luna, Omar
2010-11-06 18:32 ` Cousson, Benoit [this message]
2010-11-07 15:19 ` [PATCH v2 0/7] omap: mailbox: hwmod support and dependent cleanup patches Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD59F4D.8070903@ti.com \
--to=b-cousson@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=charu@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=omar.ramirez@ti.com \
--cc=paul@pwsan.com \
--cc=s-anna@ti.com \
--cc=subramaniam.ca@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox