From: Nishanth Menon <nm@ti.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Tony <tony@atomide.com>
Subject: Re: [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init
Date: Tue, 16 Nov 2010 08:02:53 -0600 [thread overview]
Message-ID: <4CE28F0D.6030205@ti.com> (raw)
In-Reply-To: <20101116142026.4f4740d2@surf>
Thomas Petazzoni had written, on 11/16/2010 07:20 AM, the following:
>>> would prevent you from having no OPP table (the case where a NULL OPP
>>> table is passed is tested *before* in omapX_init_opp()).
>> HUH?? NULL table to a static function - what code are you talking
>> about?? why are you so behind BUG_ON, when there are valid reasons for
>> reentry into code.
>
> In the current design, yes, there are indeed valid reasons for reentry
> into the omapX_init_opp() function, and that's exactly the point I'm
> critizicing here.
how about:
if (omap_table_init)
return -EEXIST;
does that make it better? it still retains the ability to handle both
kinds of platforms as well as not BUG out.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-11-16 14:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/3 v2] omap: opp: Add opp data>
2010-11-15 19:27 ` [PATCH v3 0/3] OMAP: Add opp data Nishanth Menon
2010-11-15 19:27 ` [PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-11-15 22:51 ` Thomas Petazzoni
2010-11-16 0:53 ` Nishanth Menon
2010-11-16 20:35 ` Tony Lindgren
2010-11-16 21:11 ` Nishanth Menon
2010-11-16 11:21 ` Thomas Petazzoni
2010-11-16 11:54 ` Nishanth Menon
2010-11-16 12:42 ` Thomas Petazzoni
2010-11-16 13:10 ` Nishanth Menon
2010-11-16 13:20 ` Thomas Petazzoni
2010-11-16 14:02 ` Nishanth Menon [this message]
2010-11-16 15:23 ` Nishanth Menon
2010-11-16 15:50 ` Thomas Petazzoni
2010-11-16 15:56 ` Nishanth Menon
2010-11-16 16:16 ` Kevin Hilman
2010-11-16 20:37 ` Tony Lindgren
2010-11-17 8:19 ` Thomas Petazzoni
2010-11-15 19:27 ` [PATCH v3 2/3] omap4: opp: add OPP table data Nishanth Menon
2010-11-15 19:27 ` [PATCH v3 3/3] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE28F0D.6030205@ti.com \
--to=nm@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox